⭐️ use macOS computer name as asset name

Author: chris-rock

providers/os/provider/detector.go

@@ -17,6 +17,7 @@ import (
 	"go.mondoo.com/cnquery/v12/providers/os/id/ids"
 	"go.mondoo.com/cnquery/v12/providers/os/id/machineid"
 	"go.mondoo.com/cnquery/v12/providers/os/id/sshhostkey"
+	"go.mondoo.com/cnquery/v12/providers/os/resources/plist"
 )
 
 // default id detectors
@@ -52,6 +53,7 @@ func (s *Service) detect(asset *inventory.Asset, conn shared.Connection) error {
 		return errors.New("failed to detect OS")
 	}
 	asset.MergePlatform(pf)
+
 	if asset.Platform.Kind == "" {
 		asset.Platform.Kind = inventory.AssetKindBaremetal
 	}
@@ -148,3 +150,19 @@ func appendRelatedAssetsFromFingerprint(f *id.PlatformFingerprint, a *inventory.
 		}
 	}
 }
+
+func (s *Service) assetName(asset *inventory.Asset, conn shared.Connection) {
+	// for macOS we want to use the computer name, therefore we detect the computer name
+	if asset.Platform.Name == "macos" {
+		// run command to get computer name and use it as asset name
+		f, err := conn.FileSystem().Open("/Library/Preferences/SystemConfiguration/preferences.plist")
+		if err == nil {
+			data, err := plist.Decode(f)
+			if err == nil {
+				if computerName, ok := data.GetString("System", "System", "ComputerName"); ok {
+					asset.Name = computerName
+				}
+			}
+		}
+	}
+}

providers/os/provider/provider.go

@@ -305,6 +305,9 @@ func (s *Service) Connect(req *plugin.ConnectReq, callback plugin.ProviderCallba
 		}
 	}
 
+	// for some assets we need to do additional asset name detection, eg. macOS
+	s.assetName(req.Asset, conn)
+
 	log.Debug().Str("asset", req.Asset.Name).Msg("detected asset")
 
 	var inv *inventory.Inventory