Revert "Configure Coordinator from ENV in init(), prepare for explicit init (#5577)" (#5628)

This reverts commit ce07339.

Author: Igor Komlew

providers/coordinator.go

@@ -46,12 +46,11 @@ var BuiltinCoreID = coreconf.Config.ID
 
 var Coordinator ProvidersCoordinator
 
-func newCoordinator(globalAutoUpdateCfg UpdateProvidersConfig) *coordinator {
+func newCoordinator() *coordinator {
 	c := &coordinator{
-		runningByID:      map[string]*RunningProvider{},
-		runtimes:         map[string]*Runtime{},
-		schema:           newExtensibleSchema(),
-		autoUpdateConfig: globalAutoUpdateCfg,
+		runningByID: map[string]*RunningProvider{},
+		runtimes:    map[string]*Runtime{},
+		schema:      newExtensibleSchema(),
 	}
 	c.schema.coordinator = c
 	return c
@@ -69,7 +68,6 @@ type coordinator struct {
 	runtimeCnt          int
 	mutex               sync.Mutex
 	schema              extensibleSchema
-	autoUpdateConfig    UpdateProvidersConfig
 }
 
 type builtinProvider struct {
@@ -110,7 +108,9 @@ func (c *coordinator) newRuntime() *Runtime {
 		providers:       map[string]*ConnectedProvider{},
 		recording:       recording.Null{},
 		shutdownTimeout: defaultShutdownTimeout,
-		AutoUpdate:      c.autoUpdateConfig,
+		AutoUpdate: UpdateProvidersConfig{
+			Enabled: true,
+		},
 	}
 
 	c.mutex.Lock()

providers/extensible_schema_test.go

@@ -13,9 +13,7 @@ import (
 
 func TestExtensibleSchema(t *testing.T) {
 	s := newExtensibleSchema()
-	s.coordinator = newCoordinator(UpdateProvidersConfig{
-		Enabled: true,
-	})
+	s.coordinator = newCoordinator()
 
 	s.Add("first", &resources.Schema{
 		Resources: map[string]*resources.ResourceInfo{

providers/providers.go

@@ -22,7 +22,6 @@ import (
 	"github.com/hashicorp/go-retryablehttp"
 	"github.com/rs/zerolog/log"
 	"github.com/spf13/afero"
-	"github.com/spf13/viper"
 	"github.com/ulikunitz/xz"
 	"go.mondoo.com/cnquery/v11/cli/config"
 	"go.mondoo.com/cnquery/v11/logger/zerologadapter"
@@ -62,20 +61,9 @@ func init() {
 
 	LastProviderInstall = time.Now().Unix()
 
-	viper.SetEnvPrefix("mondoo")
-	viper.AutomaticEnv()
-
-	autoUpdateEnabled := true
-	config.InitViperConfig()
-	if viper.IsSet("auto_update") {
-		autoUpdateEnabled = viper.GetBool("auto_update")
-	}
-
-	coordinatorCfg := UpdateProvidersConfig{
-		Enabled:         autoUpdateEnabled,
-		RefreshInterval: 60 * 60,
-	}
-	Coordinator = newCoordinator(coordinatorCfg)
+	// Initialize the global coordinator instance
+	coordinator := newCoordinator()
+	Coordinator = coordinator
 }
 
 type ProviderLookup struct {
@@ -948,9 +936,7 @@ func TryProviderUpdate(provider *Provider, update UpdateProvidersConfig) (*Provi
 	log.Info().
 		Str("installed", provider.Version).
 		Str("latest", latest).
-		Bool("update is enabled", update.Enabled).
 		Msg("found a new version for '" + provider.Name + "' provider")
-
 	provider, err = installVersion(provider.Name, latest)
 	if err != nil {
 		return nil, err