Configure Coordinator from ENV in init(), prepare for explicit init (#5577)

* skip k8s provider auto-updates in containerized environments

Author: Igor Komlew

providers/coordinator.go

@@ -46,11 +46,16 @@ var BuiltinCoreID = coreconf.Config.ID
 
 var Coordinator ProvidersCoordinator
 
-func newCoordinator() *coordinator {
+func newCoordinator(globalAutoUpdateCfg UpdateProvidersConfig) *coordinator {
+	log.Debug().
+		Bool("global auto-update is enabled", globalAutoUpdateCfg.Enabled).
+		Msg("providers.newCoordinator() is called")
+
 	c := &coordinator{
-		runningByID: map[string]*RunningProvider{},
-		runtimes:    map[string]*Runtime{},
-		schema:      newExtensibleSchema(),
+		runningByID:      map[string]*RunningProvider{},
+		runtimes:         map[string]*Runtime{},
+		schema:           newExtensibleSchema(),
+		autoUpdateConfig: globalAutoUpdateCfg,
 	}
 	c.schema.coordinator = c
 	return c
@@ -68,6 +73,7 @@ type coordinator struct {
 	runtimeCnt          int
 	mutex               sync.Mutex
 	schema              extensibleSchema
+	autoUpdateConfig    UpdateProvidersConfig
 }
 
 type builtinProvider struct {
@@ -108,9 +114,7 @@ func (c *coordinator) newRuntime() *Runtime {
 		providers:       map[string]*ConnectedProvider{},
 		recording:       recording.Null{},
 		shutdownTimeout: defaultShutdownTimeout,
-		AutoUpdate: UpdateProvidersConfig{
-			Enabled: true,
-		},
+		AutoUpdate:      c.autoUpdateConfig,
 	}
 
 	c.mutex.Lock()
@@ -245,6 +249,11 @@ func (c *coordinator) RemoveRuntime(runtime *Runtime) {
 }
 
 func (c *coordinator) GetRunningProvider(id string, update UpdateProvidersConfig) (*RunningProvider, error) {
+	log.Debug().
+		Str("id", id).
+		Bool("update is enabled", update.Enabled).
+		Msg("coordinator.GetRunningProvider() is called")
+
 	c.mutex.Lock()
 	defer c.mutex.Unlock()
 	running := c.runningByID[id]

providers/extensible_schema_test.go

@@ -13,7 +13,9 @@ import (
 
 func TestExtensibleSchema(t *testing.T) {
 	s := newExtensibleSchema()
-	s.coordinator = newCoordinator()
+	s.coordinator = newCoordinator(UpdateProvidersConfig{
+		Enabled: true,
+	})
 
 	s.Add("first", &resources.Schema{
 		Resources: map[string]*resources.ResourceInfo{

providers/providers.go

@@ -22,6 +22,7 @@ import (
 	"github.com/hashicorp/go-retryablehttp"
 	"github.com/rs/zerolog/log"
 	"github.com/spf13/afero"
+	"github.com/spf13/viper"
 	"github.com/ulikunitz/xz"
 	"go.mondoo.com/cnquery/v11/cli/config"
 	"go.mondoo.com/cnquery/v11/logger/zerologadapter"
@@ -61,9 +62,24 @@ func init() {
 
 	LastProviderInstall = time.Now().Unix()
 
-	// Initialize the global coordinator instance
-	coordinator := newCoordinator()
-	Coordinator = coordinator
+	viper.SetEnvPrefix("mondoo")
+	viper.AutomaticEnv()
+
+	autoUpdateEnabled := true
+	config.InitViperConfig()
+	if viper.IsSet("auto_update") {
+		autoUpdateEnabled = viper.GetBool("auto_update")
+	}
+
+	log.Info().
+		Bool("autoUpdateEnabled", autoUpdateEnabled).
+		Msg("cnquery.providers.init(): initializing global Coordinator from ENV.")
+
+	coordinatorCfg := UpdateProvidersConfig{
+		Enabled:         autoUpdateEnabled,
+		RefreshInterval: 60 * 60,
+	}
+	Coordinator = newCoordinator(coordinatorCfg)
 }
 
 type ProviderLookup struct {
@@ -936,7 +952,9 @@ func TryProviderUpdate(provider *Provider, update UpdateProvidersConfig) (*Provi
 	log.Info().
 		Str("installed", provider.Version).
 		Str("latest", latest).
+		Bool("update is enabled", update.Enabled).
 		Msg("found a new version for '" + provider.Name + "' provider")
+
 	provider, err = installVersion(provider.Name, latest)
 	if err != nil {
 		return nil, err

providers/runtime.go

@@ -141,6 +141,11 @@ func (r *Runtime) setProviderConnection(c *plugin.ConnectRes, err error) {
 }
 
 func (r *Runtime) addProvider(id string) (*ConnectedProvider, error) {
+	log.Debug().
+		Str("id", id).
+		Bool("update is enabled", r.AutoUpdate.Enabled).
+		Msg("Runtime.addProvider() is called")
+
 	// TODO: we need to detect only the shared running providers
 	running, err := r.coordinator.GetRunningProvider(id, r.AutoUpdate)
 	if err != nil {