✨ implement vault delete for berglas (#7078)

* ✨ implement vault delete for berglas

Signed-off-by: Ivan Milchev <ivan@mondoo.com>

* address comments

Signed-off-by: Ivan Milchev <ivan@mondoo.com>

---------

Signed-off-by: Ivan Milchev <ivan@mondoo.com>

Author: imilchev

providers-sdk/v1/vault/awsparameterstore/parameterstore.go

@@ -70,3 +70,7 @@ func (v *Vault) Get(ctx context.Context, id *vault.SecretID) (*vault.Secret, err
 func (v *Vault) Set(ctx context.Context, cred *vault.Secret) (*vault.SecretID, error) {
 	return nil, errors.New("not implemented")
 }
+
+func (v *Vault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	return nil, vault.NotImplementedError
+}

providers-sdk/v1/vault/awssecretsmanager/secretsmanager.go

@@ -102,6 +102,10 @@ func (v *Vault) Set(ctx context.Context, cred *vault.Secret) (*vault.SecretID, e
 	return &vault.SecretID{Key: *o.ARN}, err
 }
 
+func (v *Vault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	return nil, vault.NotImplementedError
+}
+
 func (v *Vault) updateSecret(ctx context.Context, cred *vault.Secret) (*vault.SecretID, error) {
 	var kmsKeyID *string
 	if len(v.kmsKeyID) > 0 {

providers-sdk/v1/vault/cache/cached_vault.go

@@ -42,3 +42,12 @@ func (c *cachedVault) Get(ctx context.Context, id *vault.SecretID) (*vault.Secre
 func (c *cachedVault) Set(ctx context.Context, s *vault.Secret) (*vault.SecretID, error) {
 	return c.vault.Set(ctx, s)
 }
+
+func (c *cachedVault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	res, err := c.vault.Delete(ctx, id)
+	if err != nil {
+		return nil, err
+	}
+	delete(c.secrets, id.Key)
+	return res, nil
+}

providers-sdk/v1/vault/gcpberglas/berglas.go

@@ -114,6 +114,28 @@ func (v *Vault) Get(ctx context.Context, id *vault.SecretID) (*vault.Secret, err
 	}, nil
 }
 
+func (v *Vault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	c, err := v.client(ctx)
+	if err != nil {
+		return nil, err
+	}
+
+	berglasInfo, err := getBerglasStorageInfo(id.Key)
+	if err != nil {
+		return nil, err
+	}
+
+	err = c.Delete(ctx, &berglas.StorageDeleteRequest{
+		Bucket: berglasInfo.bucket,
+		Object: berglasInfo.object,
+	})
+	if err != nil {
+		return nil, err
+	}
+
+	return &vault.Empty{}, nil
+}
+
 func (v *Vault) Set(ctx context.Context, cred *vault.Secret) (*vault.SecretID, error) {
 	if len(v.kmsKeyID) == 0 {
 		return nil, errors.New("specified KMS key id is empty")

providers-sdk/v1/vault/gcpsecretmanager/secretmanager.go

@@ -87,3 +87,7 @@ func (v *Vault) Get(ctx context.Context, id *vault.SecretID) (*vault.Secret, err
 func (v *Vault) Set(ctx context.Context, cred *vault.Secret) (*vault.SecretID, error) {
 	return nil, errors.New("not implemented")
 }
+
+func (v *Vault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	return nil, vault.NotImplementedError
+}

providers-sdk/v1/vault/hashivault/hashivault.go

@@ -126,3 +126,7 @@ func secretData(s *api.Secret) ([]byte, error) {
 func (v *Vault) Set(ctx context.Context, cred *vault.Secret) (*vault.SecretID, error) {
 	return nil, errors.New("not implemented")
 }
+
+func (v *Vault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	return nil, vault.NotImplementedError
+}

providers-sdk/v1/vault/inmemory/inmemory.go

@@ -60,3 +60,15 @@ func (v *inmemoryVault) Get(ctx context.Context, id *vault.SecretID) (*vault.Sec
 	}
 	return s, nil
 }
+
+func (v *inmemoryVault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	if id == nil {
+		return nil, errors.New("secret id is empty")
+	}
+
+	if _, ok := v.secrets[id.Key]; !ok {
+		return nil, vault.NotFoundError
+	}
+	delete(v.secrets, id.Key)
+	return &vault.Empty{}, nil
+}

providers-sdk/v1/vault/keyring/keyring.go

@@ -125,3 +125,7 @@ func (v *Vault) Get(ctx context.Context, id *vault.SecretID) (*vault.Secret, err
 		Encoding: vault.SecretEncoding_encoding_json,
 	}, nil
 }
+
+func (v *Vault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	return nil, vault.NotImplementedError
+}

providers-sdk/v1/vault/mock/mock_vault.go

@@ -62,3 +62,7 @@ func (v *Vault) Get(ctx context.Context, id *vault.SecretID) (*vault.Secret, err
 func (v *Vault) Set(ctx context.Context, cred *vault.Secret) (*vault.SecretID, error) {
 	return nil, errors.New("not implemented")
 }
+
+func (v *Vault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	return nil, vault.NotImplementedError
+}

providers-sdk/v1/vault/multivault/multivault.go

@@ -56,3 +56,7 @@ func (m *multiVault) Get(ctx context.Context, id *vault.SecretID) (*vault.Secret
 
 	return nil, vault.NotFoundError
 }
+
+func (m *multiVault) Delete(ctx context.Context, id *vault.SecretID) (*vault.Empty, error) {
+	return nil, vault.NotImplementedError
+}