Commit dcaf848
🐛 Address review comments: restore expect.txt, fix stored fields, fix ID collision
- Restore KSK and kustomize to spell check expect.txt (both still used in
checked .lr files)
- Change notebookinstancedetails ipAddressType, platformIdentifier,
volumeSizeInGB, failureReason from stored properties to computed methods
(they are populated via Internal struct cache, not CreateResource)
- Fix clusterInstanceGroup ID collision by including cluster name in the
composite ID (region/clusterName/instanceGroupName)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 0d8207c commit dcaf848
File tree
4 files changed
+21
-9
lines changed- .github/actions/spelling
- providers/aws/resources
4 files changed
+21
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| 148 | + | |
148 | 149 | | |
| 150 | + | |
149 | 151 | | |
150 | 152 | | |
151 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1702 | 1702 | | |
1703 | 1703 | | |
1704 | 1704 | | |
1705 | | - | |
| 1705 | + | |
1706 | 1706 | | |
1707 | | - | |
| 1707 | + | |
1708 | 1708 | | |
1709 | | - | |
| 1709 | + | |
1710 | 1710 | | |
1711 | | - | |
| 1711 | + | |
1712 | 1712 | | |
1713 | 1713 | | |
1714 | 1714 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1979 | 1979 | | |
1980 | 1980 | | |
1981 | 1981 | | |
| 1982 | + | |
1982 | 1983 | | |
1983 | 1984 | | |
1984 | 1985 | | |
| |||
2073 | 2074 | | |
2074 | 2075 | | |
2075 | 2076 | | |
| 2077 | + | |
2076 | 2078 | | |
2077 | 2079 | | |
2078 | 2080 | | |
2079 | 2081 | | |
2080 | 2082 | | |
2081 | | - | |
| 2083 | + | |
2082 | 2084 | | |
2083 | 2085 | | |
2084 | 2086 | | |
| |||
0 commit comments