Skip to content

Commit dcaf848

Browse files
tas50claude
andcommitted
🐛 Address review comments: restore expect.txt, fix stored fields, fix ID collision
- Restore KSK and kustomize to spell check expect.txt (both still used in checked .lr files) - Change notebookinstancedetails ipAddressType, platformIdentifier, volumeSizeInGB, failureReason from stored properties to computed methods (they are populated via Internal struct cache, not CreateResource) - Fix clusterInstanceGroup ID collision by including cluster name in the composite ID (region/clusterName/instanceGroupName) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 0d8207c commit dcaf848

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

.github/actions/spelling/expect.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ kerberoastable
145145
keyspace
146146
kqueue
147147
krbtgt
148+
KSK
148149
kustomization
150+
kustomize
149151
kubenet
150152
labelmatchstatement
151153
launchconfiguration

providers/aws/resources/aws.lr

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1702,13 +1702,13 @@ private aws.sagemaker.notebookinstancedetails @defaults("arn") {
17021702
// VPC subnet the notebook instance is deployed in
17031703
subnet() aws.vpc.subnet
17041704
// IP address type: ipv4 or dualstack
1705-
ipAddressType string
1705+
ipAddressType() string
17061706
// Platform identifier of the notebook instance runtime environment
1707-
platformIdentifier string
1707+
platformIdentifier() string
17081708
// Size (in GB) of the ML storage volume attached to the instance
1709-
volumeSizeInGB int
1709+
volumeSizeInGB() int
17101710
// Failure reason if the notebook instance is in a failed state
1711-
failureReason string
1711+
failureReason() string
17121712
// IAM role associated with the instance
17131713
iamRole() aws.iam.role
17141714
// VPC security groups associated with the instance

providers/aws/resources/aws.lr.go

Lines changed: 12 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

providers/aws/resources/aws_sagemaker.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1979,6 +1979,7 @@ func (a *mqlAwsSagemakerCluster) instanceGroups() ([]any, error) {
19791979
return nil, err
19801980
}
19811981
igRes := mqlIG.(*mqlAwsSagemakerClusterInstanceGroup)
1982+
igRes.cacheClusterName = a.Name.Data
19821983
igRes.cacheExecutionRole = ig.ExecutionRole
19831984
igRes.cacheLifecycleConfig = ig.LifeCycleConfig
19841985
res = append(res, mqlIG)
@@ -2073,12 +2074,13 @@ func (a *mqlAwsSagemakerCluster) nodes() ([]any, error) {
20732074
}
20742075

20752076
type mqlAwsSagemakerClusterInstanceGroupInternal struct {
2077+
cacheClusterName string
20762078
cacheExecutionRole *string
20772079
cacheLifecycleConfig any
20782080
}
20792081

20802082
func (a *mqlAwsSagemakerClusterInstanceGroup) id() (string, error) {
2081-
return a.Region.Data + "/" + a.InstanceGroupName.Data, nil
2083+
return a.Region.Data + "/" + a.cacheClusterName + "/" + a.InstanceGroupName.Data, nil
20822084
}
20832085

20842086
func (a *mqlAwsSagemakerClusterInstanceGroup) iamRole() (*mqlAwsIamRole, error) {

0 commit comments

Comments
 (0)