Skip to content

Commit e3ffb22

Browse files
tas50claude
andauthored
🐛 Fix GitHub Actions workflow bugs and typos (#6865)
* 🐛 Fix GitHub Actions workflow bugs and typos - reusable-lint-providers: pass BASE_SHA from PR context so only-new-issues actually filters to new issues instead of silently doing nothing - pr-test-lint: add pull_request trigger so fork PRs get tested - providers.yaml: quote step outputs to prevent shell word-splitting - Fix typos: "Provider PAth" → "Provider Path", "becasue" → "because", "select to build" → "selected to build" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * 🧹 Remove pull_request trigger from pr-test-lint.yml Self-hosted runners should not execute untrusted fork code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 86cd1aa commit e3ffb22

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

.github/workflows/pr-test-lint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191

9292
- name: Set provider env
9393
run: echo "PROVIDERS_PATH=${PWD}/.providers" >> $GITHUB_ENV
94-
- name: Display Provider PAth
94+
- name: Display Provider Path
9595
run: echo $PROVIDERS_PATH
9696

9797
- name: Test mql
@@ -128,7 +128,7 @@ jobs:
128128

129129
- name: Set provider env
130130
run: echo "PROVIDERS_PATH=${PWD}/.providers" >> $GITHUB_ENV
131-
- name: Display Provider PAth
131+
- name: Display Provider Path
132132
run: echo $PROVIDERS_PATH
133133

134134
- name: Test mql CLI and Providers

.github/workflows/providers.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ jobs:
9494
- name: Build List
9595
run: |
9696
echo "=== Providers detected:"
97-
echo ${{ steps.providers.outputs.providers }}
97+
echo '${{ steps.providers.outputs.providers }}'
9898
99-
echo "=== Providers select to build:"
100-
echo ${{ steps.providers.outputs.build_list }}
99+
echo "=== Providers selected to build:"
100+
echo '${{ steps.providers.outputs.build_list }}'
101101
102102
provider-build:
103103
name: "${{ matrix.provider }}"

.github/workflows/release-providers.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
# https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#push-using-ssh-deploy-keys
2929
# tl;dr:
3030
# The GITHUB_TOKEN is limited when creating PRs from a workflow
31-
# becasue of that we use a ssh key for which the limitations do not apply
31+
# because of that we use a ssh key for which the limitations do not apply
3232
- name: Checkout code
3333
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
3434
with:

.github/workflows/reusable-lint-providers.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,13 @@ jobs:
3535
- name: Run golangci-lint on all providers
3636
env:
3737
ONLY_NEW_ISSUES: ${{ inputs.only-new-issues }}
38+
BASE_SHA: ${{ github.event.pull_request.base.sha }}
3839
run: |
3940
failed=""
4041
extra_args=""
4142
if [ "$ONLY_NEW_ISSUES" = "true" ] && [ -n "${BASE_SHA}" ]; then
42-
git fetch origin "${BASE_SHA}"
43-
extra_args="--new-from-rev=${BASE_SHA}"
43+
git fetch origin "${BASE_SHA}" --depth=1
44+
extra_args="--new-from-rev=${BASE_SHA}"
4445
fi
4546
for provider in providers/*/; do
4647
# Skip providers without go.mod (they are part of the main module)

0 commit comments

Comments
 (0)