Skip to content

Commit e98c1a7

Browse files
vjeffreyclaude
andcommitted
πŸ› Fix backupdr.dataSources.list and remove fake recommender permission
- backupdr.dataSources.list β†’ backupdr.bvdataSources.list (backup vault data sources use the bvdataSources resource type) - Remove recommender.recommendations.list β€” not a real permission; the Recommender API uses type-specific permissions that can't be auto-derived from the code Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 4c2d2c5 commit e98c1a7

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

β€Žproviders-sdk/v1/util/permissions/permissions.goβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -916,6 +916,15 @@ var gcpPermissionOverrides = map[string]map[string]string{
916916
"serviceusage": {
917917
"GetService": "serviceusage.services.get",
918918
},
919+
"backupdr": {
920+
"ListDataSources": "backupdr.bvdataSources.list",
921+
},
922+
"recommender": {
923+
// recommender.recommendations.list is not a real permission; the Recommender
924+
// API uses type-specific permissions (e.g., recommender.iamPolicyRecommendations.list).
925+
// These can't be auto-derived from the code, so skip the generic form.
926+
"ListRecommendations": "",
927+
},
919928
}
920929

921930
// gcpSkipMethods lists method names that match isGCPAPIMethod patterns but are

β€Žproviders/gcp/resources/gcp.permissions.jsonβ€Ž

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"provider": "gcp",
33
"version": "13.3.0",
4-
"generated_at": "2026-03-31T12:16:16-06:00",
4+
"generated_at": "2026-03-31T13:38:39-06:00",
55
"permissions": [
66
"accessapproval.settings.get",
77
"aiplatform.datasets.list",
@@ -17,7 +17,7 @@
1717
"artifactregistry.repositories.list",
1818
"backupdr.backupPlans.list",
1919
"backupdr.backupVaults.list",
20-
"backupdr.dataSources.list",
20+
"backupdr.bvdataSources.list",
2121
"backupdr.managementServers.list",
2222
"bigtable.appProfiles.list",
2323
"binaryauthorization.policy.get",
@@ -83,7 +83,6 @@
8383
"privateca.caPools.list",
8484
"privateca.certificateAuthorities.list",
8585
"privateca.certificates.list",
86-
"recommender.recommendations.list",
8786
"redis.backups.list",
8887
"redis.clusters.list",
8988
"redis.instances.list",
@@ -194,7 +193,7 @@
194193
"source_file": "backupdr.go"
195194
},
196195
{
197-
"permission": "backupdr.dataSources.list",
196+
"permission": "backupdr.bvdataSources.list",
198197
"service": "backupdr",
199198
"action": "ListDataSources",
200199
"source_file": "backupdr.go"
@@ -607,12 +606,6 @@
607606
"action": "ListCertificates",
608607
"source_file": "privateca.go"
609608
},
610-
{
611-
"permission": "recommender.recommendations.list",
612-
"service": "recommender",
613-
"action": "ListRecommendations",
614-
"source_file": "recommendations.go"
615-
},
616609
{
617610
"permission": "redis.backups.list",
618611
"service": "redis",
@@ -676,7 +669,7 @@
676669
{
677670
"permission": "resourcemanager.projects.list",
678671
"service": "resourcemanager",
679-
"action": "Projects.List",
672+
"action": "Projects.Search",
680673
"source_file": "project.go"
681674
},
682675
{

0 commit comments

Comments
Β (0)