✨ Use rpm database path as evidence instead of files contained in the rpm

This alignes the rpm packages with dpkg and Windows:
#5399

#5770
Signed-off-by: Christian Zunker <christian@mondoo.com>

Author: czunker

providers/os/resources/packages/rpm_packages.go

@@ -297,30 +297,12 @@ func (rpm *RpmPkgManager) staticList() ([]Package, error) {
 
 		rpmPkg := newRpmPackage(rpm.platform, pkg.Name, version, pkg.Arch, epoch, cleanupVendorName(pkg.Vendor), pkg.Summary)
 
-		// determine all files attached
-		records := []FileRecord{}
-		files, err := pkg.InstalledFiles()
-		if err == nil {
-			for _, record := range files {
-				records = append(records, FileRecord{
-					Path: record.Path,
-					Digest: PkgDigest{
-						Value:     record.Digest,
-						Algorithm: pkg.DigestAlgorithm.String(),
-					},
-					FileInfo: PkgFileInfo{
-						Mode:  record.Mode,
-						Flags: int32(record.Flags),
-						Owner: record.Username,
-						Group: record.Groupname,
-						Size:  int64(record.Size),
-					},
-				})
-			}
-		}
-
 		rpmPkg.FilesAvailable = PkgFilesIncluded
-		rpmPkg.Files = records
+		rpmPkg.Files = []FileRecord{
+			{
+				Path: detectedPath,
+			},
+		}
 		resultList = append(resultList, rpmPkg)
 	}
 
@@ -338,10 +320,10 @@ func (rpm *RpmPkgManager) Files(name string, version string, arch string) ([]Fil
 		// nothing to do since the data is already attached to the package
 		return nil, nil
 	} else {
-		// we need to fetch the files from the running system
-		cmd, err := rpm.conn.RunCommand("rpm -ql " + name)
+		// This returns the path to the RPM database
+		cmd, err := rpm.conn.RunCommand("rpm -E '%{_dbpath}'")
 		if err != nil {
-			return nil, errors.Wrap(err, "could not read package files")
+			return nil, errors.Wrap(err, "could not rpm database path")
 		}
 		fileRecords := []FileRecord{}
 		scanner := bufio.NewScanner(cmd.Stdout)

providers/os/resources/packages/rpm_packages_test.go

@@ -191,9 +191,8 @@ func TestRedhat8Parser(t *testing.T) {
 	}
 	pkgFiles, err := mgr.Files(p.Name, p.Version, p.Arch)
 	require.NoError(t, err)
-	assert.Equal(t, 15, len(pkgFiles), "detected the right amount of package files")
-	assert.Contains(t, pkgFiles, FileRecord{Path: "/usr/share/doc/which"})
-	assert.Contains(t, pkgFiles, FileRecord{Path: "/usr/share/info/which.info.gz"})
+	assert.Equal(t, 1, len(pkgFiles), "detected the right amount of package files")
+	assert.Contains(t, pkgFiles, FileRecord{Path: "/var/lib/rpm/rpmdb.sqlite"})
 }
 
 func TestPhoton4ImageParser(t *testing.T) {

providers/os/resources/packages/testdata/packages_redhat8.toml

@@ -1,6 +1,9 @@
 [commands."command -v rpm"]
 stdout="/usr/bin/rpm"
 
+[commands."rpm -E '%{_dbpath}'"]
+stdout="/var/lib/rpm/rpmdb.sqlite"
+
 [commands."rpm -qa --queryformat '%{NAME} %{EPOCHNUM}:%{VERSION}-%{RELEASE} %{ARCH}__%{VENDOR}__%{SUMMARY}\\n'"]
 stdout="""
 tzdata 0:2021c-1.el8 noarch__Red Hat, Inc.__Timezone data
@@ -214,4 +217,4 @@ stdout="""
 /usr/share/licenses/which
 /usr/share/licenses/which/COPYING
 /usr/share/man/man1/which.1.gz
-"""
+"""