fixup: update comments, share handler typing

Author: Anemy

src/hooks/use-field-selection.tsx

@@ -1,12 +1,12 @@
 import React, { createContext, useContext, useMemo, ReactNode } from 'react';
 
-import { FieldId } from '@/types';
+import { OnFieldClickHandler } from '@/types';
 
 interface FieldSelectionContextType {
   enabled: boolean;
   fieldProps:
     | {
-        onClick: (event: React.MouseEvent, params: { id: FieldId; nodeId: string }) => void;
+        onClick: OnFieldClickHandler;
       }
     | undefined;
 }
@@ -15,7 +15,7 @@ const FieldSelectionContext = createContext<FieldSelectionContextType | undefine
 
 interface FieldSelectionProviderProps {
   children: ReactNode;
-  onFieldClick?: (event: React.MouseEvent, params: { id: FieldId; nodeId: string }) => void;
+  onFieldClick?: OnFieldClickHandler;
 }
 
 export const FieldSelectionProvider: React.FC<FieldSelectionProviderProps> = ({ children, onFieldClick }) => {

src/types/component-props.ts

@@ -9,6 +9,17 @@ import { NodeProps, FieldId } from '@/types/node';
  */
 export type OnConnectHandler = (connection: Connection) => void;
 
+/**
+ * Called when a selectable field is clicked.
+ */
+export type OnFieldClickHandler = (
+  event: ReactMouseEvent,
+  params: {
+    id: FieldId;
+    nodeId: string;
+  },
+) => void;
+
 /**
  * Called when the canvas (pane) is clicked.
  */
@@ -151,13 +162,7 @@ export interface DiagramProps {
   /**
    * Callback when the user clicks on a selectable field.
    */
-  onFieldClick?: (
-    event: ReactMouseEvent,
-    params: {
-      id: FieldId;
-      nodeId: string;
-    },
-  ) => void;
+  onFieldClick?: OnFieldClickHandler;
 
   /**
    * Whether the diagram should pan when dragging elements.

src/types/node.ts

@@ -174,12 +174,12 @@ export interface NodeField {
   hoverVariant?: NodeFieldHoverVariant;
 
   /**
-   * Indicates if the node can be selected.
+   * Indicates if the field can be selected.
    */
   selectable?: boolean;
 
   /**
-   * Indicates if the node is currently selected.
+   * Indicates if the field is currently selected.
    */
   selected?: boolean;
 }