Skip to content

feat(NODE-7404): enable stack-protector-strong flag on Linux#306

Merged
tadjik1 merged 2 commits intomongodb-js:mainfrom
rzhao271:rzhao271/fsp
Feb 2, 2026
Merged

feat(NODE-7404): enable stack-protector-strong flag on Linux#306
tadjik1 merged 2 commits intomongodb-js:mainfrom
rzhao271:rzhao271/fsp

Conversation

@rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jan 22, 2026

Description

Summary of Changes

This PR enables stack canaries on Linux and is a follow-up to #190.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@rzhao271 rzhao271 requested a review from a team as a code owner January 22, 2026 00:19
@tadjik1 tadjik1 self-assigned this Jan 27, 2026
@tadjik1 tadjik1 added Primary Review In Review with primary reviewer, not yet ready for team's eyes tracked-in-jira labels Jan 27, 2026
Copy link
Contributor

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rzhao271, thanks a lot for the PR! I left a couple of small comments; please let me know what you think about them.

@rzhao271
Copy link
Contributor Author

Hi @tadjik1, thanks for the review! I have updated the PR.

@tadjik1 tadjik1 requested a review from a team January 28, 2026 09:45
@tadjik1 tadjik1 added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 28, 2026
Copy link
Contributor

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @rzhao271!

@tadjik1 tadjik1 requested a review from a team January 28, 2026 09:48
@tadjik1 tadjik1 merged commit d16dd0a into mongodb-js:main Feb 2, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team tracked-in-jira

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments