chore: switch to @mongodb-js/device-id
#2446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
added
the
no-title-validation
addaleax
approved these changes
May 29, 2025
gagik
commented
Jun 2, 2025
| public setupTelemetryPromise: Promise<void> = Promise.resolve(); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| private resolveDeviceId: (value: string) => void = () => {}; | ||
| private readonly telemetrySetup: AbortController = new AbortController(); |
There was a problem hiding this comment.
not a huge fan of this name, maybe deviceIdResolution though I was thinking this would be shared by the entire setup.
I could also call it abortController but seems like a implementation detail.
There was a problem hiding this comment.
I do think it's odd to refer to an abort mechanism as ...Setup 🙂 No strong feelings here but maybe just telemetrySetupAbort?
addaleax
approved these changes
Jun 2, 2025
gagik
force-pushed
the
gagik/use-shared-device-id
branch
from
003520f to
7850337
Compare
addaleax
reviewed
Jun 2, 2025
| }), | ||
| ]); | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const getMachineId = require('native-machine-id').getMachineId; |
There was a problem hiding this comment.
This was previously in a try/catch (to avoid crashing mongosh in situations in which we cannot load this), should it continue to be?
gagik
force-pushed
the
gagik/use-shared-device-id
branch
from
aea1f71 to
cf2e0ef
Compare
gagik
force-pushed
the
gagik/use-shared-device-id
branch
from
cf2e0ef to
377de04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is meant to minimize code replication and to make sure the approach we're taking with hashing is consistent and timeouts are automatically handled.
See mongodb-js/devtools-shared#532