fix: hide preset connections from the Remove Connection command VSCODE-674 (#969)

Co-authored-by: Nikola Irinchev <[email protected]>

Author: gagik

src/connectionController.ts

@@ -743,7 +743,15 @@ export default class ConnectionController {
   async onRemoveMongoDBConnection(): Promise<boolean> {
     log.info('mdb.removeConnection command called');
 
-    const connectionIds = Object.keys(this._connections);
+    const connectionIds = Object.entries(this._connections)
+      .map(([id, connection]) => {
+        return { id, connection };
+      })
+      .filter(
+        ({ connection }) =>
+          connection.source !== 'globalSettings' &&
+          connection.source !== 'workspaceSettings'
+      );
 
     if (connectionIds.length === 0) {
       // No active connection(s) to remove.
@@ -753,15 +761,15 @@ export default class ConnectionController {
     }
 
     if (connectionIds.length === 1) {
-      return this.removeMongoDBConnection(connectionIds[0]);
+      return this.removeMongoDBConnection(connectionIds[0].id);
     }
 
     // There is more than 1 possible connection to remove.
     // We attach the index of the connection so that we can infer their pick.
     const connectionNameToRemove: string | undefined =
       await vscode.window.showQuickPick(
         connectionIds.map(
-          (id, index) => `${index + 1}: ${this._connections[id].name}`
+          ({ connection }, index) => `${index + 1}: ${connection.name}`
         ),
         {
           placeHolder: 'Choose a connection to remove...',
@@ -775,7 +783,7 @@ export default class ConnectionController {
     // We attach the index of the connection so that we can infer their pick.
     const connectionIndexToRemove =
       Number(connectionNameToRemove.split(':', 1)[0]) - 1;
-    const connectionIdToRemove = connectionIds[connectionIndexToRemove];
+    const connectionIdToRemove = connectionIds[connectionIndexToRemove].id;
 
     return this.removeMongoDBConnection(connectionIdToRemove);
   }

src/test/suite/connectionController.test.ts

@@ -135,6 +135,53 @@ suite('Connection Controller Test Suite', function () {
     expect(successfullyRemovedMongoDBConnection).to.be.false;
   });
 
+  test('"removeMongoDBConnection()" hides preset connections', async () => {
+    const connectionBase: Omit<LoadedConnection, 'id' | 'name'> = {
+      connectionOptions: {
+        connectionString: 'localhost:3000',
+      },
+      storageLocation: StorageLocation.NONE,
+      secretStorageLocation: SecretStorageLocation.SecretStorage,
+    };
+
+    testConnectionController._connections['1234'] = {
+      ...connectionBase,
+      name: 'valid 1',
+      id: '1234',
+    };
+    testConnectionController._connections['5678'] = {
+      ...connectionBase,
+      name: 'valid 2',
+      id: '5678',
+      source: 'user',
+    };
+    testConnectionController._connections['3333'] = {
+      ...connectionBase,
+      id: '3333',
+      name: 'invalid 1',
+      source: 'workspaceSettings',
+    };
+    testConnectionController._connections['3333'] = {
+      ...connectionBase,
+      id: '3333',
+      name: 'invalid 2',
+      source: 'globalSettings',
+    };
+
+    const showQuickPickStub = sinon
+      .stub(vscode.window, 'showQuickPick')
+      .resolves(undefined);
+    const successfullyRemovedMongoDBConnection =
+      await testConnectionController.onRemoveMongoDBConnection();
+
+    expect(showErrorMessageStub).not.called;
+    expect(showQuickPickStub.firstCall.firstArg).deep.equal([
+      '1: valid 1',
+      '2: valid 2',
+    ]);
+    expect(successfullyRemovedMongoDBConnection).to.be.false;
+  });
+
   test('when adding a new connection it disconnects from the current connection', async () => {
     const succesfullyConnected =
       await testConnectionController.addNewConnectionStringAndConnect(