Dop 5395 (#1084)

* DOP-5395 hardcode parser user to docsworker-xlarge for persistence module

* DOP-5395 add comments

* DOP-5395 use replace

* DOP-5395 replace parser user for every page id in persistence module

* DOP-5395 lint

* DOP-5395 remove unecessary replace for page id prefix

* DOP-5395 fixing page id updating

Author: anabellabuckvar

modules/persistence/src/services/pages/index.ts

@@ -311,13 +311,14 @@ const updatePages = async (pages: Page[], collection: string, githubUser: string
 
 export const insertAndUpdatePages = async (buildId: ObjectId, zip: AdmZip, githubUser: string) => {
   try {
-    const pages = pagesFromZip(zip, githubUser);
-
+    
     // TEMPORARY FIX FOR NETLIFY BUILDS
     // TODO: DOP-5405 remove parser user from page id altogether
-    for (const page of pages) {
+
+    const pages = pagesFromZip(zip, githubUser).map((page: Page) => {
       page.page_id = page.page_id.replace('buildbot', 'docsworker-xlarge');
-    }
+      return page;
+    });
 
     const ops: PromiseLike<any>[] = [insert(pages, COLLECTION_NAME, buildId, true)];