fix(NODE-7414): add copy method to ByteUtils#867
Conversation
addaleax
left a comment
There was a problem hiding this comment.
Does this need a separate implementation for Node.js? Always using the web one would result in consistent validation and otherwise no major downsides, right?
We can use the web implementation in both cases, but I don't think we should. Other operations in |
tadjik1
left a comment
There was a problem hiding this comment.
Great implementation, decent test coverage, well done @PavelSafronov!
Description
Summary of Changes
Add
copymethod to ByteUtils, with web and Node implementations.What is the motivation for this change?
Add a common
copymethod which will be used by Node DriverRelease Highlight
Buffer.copy()now present in ByteUtilsByteUtils now contains a
copy()method, we behaves identically to Nodejs'Buffer.copy()method.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript