Skip to content

Commit 1db1244

Browse files
authored
RUBY-3461 Enable tests that require failCommand with appName on initial handshake before 4.9 (#2901)
1 parent 2b639a7 commit 1db1244

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

spec/spec_tests/data/client_side_operations_timeout/command-execution.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ description: "timeoutMS behaves correctly during command execution"
33
schemaVersion: "1.9"
44

55
runOnRequirements:
6-
# The appName filter cannot be used to set a fail point on connection handshakes until server version 4.9 due to
7-
# SERVER-49220/SERVER-49336.
8-
- minServerVersion: "4.9"
6+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
7+
- minServerVersion: "4.4.7"
98
# Skip load-balanced and serverless which do not support RTT measurements.
109
topologies: [ single, replicaset, sharded ]
1110
serverless: forbid

spec/spec_tests/data/sdam_unified/hello-command-error.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
22
description: hello-command-error
33

4-
schemaVersion: "1.10"
4+
schemaVersion: "1.4"
55

66
runOnRequirements:
7-
# failCommand appName requirements
8-
- minServerVersion: "4.9"
7+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
8+
- minServerVersion: "4.4.7"
99
serverless: forbid
1010
topologies: [ single, replicaset, sharded ]
1111

spec/spec_tests/data/sdam_unified/hello-network-error.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
22
description: hello-network-error
33

4-
schemaVersion: "1.10"
4+
schemaVersion: "1.4"
55

66
runOnRequirements:
7-
# failCommand appName requirements
8-
- minServerVersion: "4.9"
7+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
8+
- minServerVersion: "4.4.7"
99
serverless: forbid
1010
topologies: [ single, replicaset, sharded ]
1111

@@ -140,7 +140,6 @@ tests:
140140
# network error. Use "times: 4" to increase the probability that the
141141
# Monitor check fails since the RTT hello may trigger this failpoint one
142142
# or many times as well.
143-
# The ruby driver only needs to fail twice because the RTT updates topology.
144143
- name: failPoint
145144
object: testRunner
146145
arguments:

spec/spec_tests/data/sdam_unified/interruptInUse-pool-clear.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ schemaVersion: "1.11"
55

66
runOnRequirements:
77
# failCommand appName requirements
8-
- minServerVersion: "4.9"
8+
- minServerVersion: "4.4"
99
serverless: forbid
1010
topologies: [ replicaset, sharded ]
1111

@@ -338,3 +338,4 @@ tests:
338338
databaseName: *databaseName
339339
documents:
340340
- { _id: 1, a : bar }
341+

spec/spec_tests/data/sdam_unified/minPoolSize-error.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
22
description: minPoolSize-error
33

4-
schemaVersion: "1.10"
4+
schemaVersion: "1.4"
55

66
runOnRequirements:
7-
# failCommand appName requirements
8-
- minServerVersion: "4.9"
7+
# Require SERVER-49336 for failCommand + appName on the initial handshake.
8+
- minServerVersion: "4.4.7"
99
serverless: forbid
1010
topologies:
1111
- single

0 commit comments

Comments
 (0)