CLOUDP-378545: Add new GCP PSC command to atlas cli (#4455)

Author: celinatala-1

docs/command/atlas-privateEndpoints-gcp-create.txt

@@ -45,6 +45,10 @@ Options
      - string
      - false
      - Output format. Valid values are json, json-path, go-template, or go-template-file. To see the full output, use the -o json option.
+   * - --portMappingEnabled
+     - 
+     - false
+     - Flag that indicates whether this endpoint service uses PSC port-mapping. This is only applicable for GCP Private Endpoint Services.
    * - --projectId
      - string
      - false
@@ -86,4 +90,4 @@ Examples
 .. code-block::
    :copyable: false
 
-   atlas privateEndpoints gcp create --region CENTRAL_US
+   atlas privateEndpoints gcp create --region CENTRAL_US --portMappingEnabled

internal/cli/privateendpoints/gcp/create.go

@@ -37,8 +37,9 @@ type PrivateEndpointCreator interface {
 type CreateOpts struct {
 	cli.ProjectOpts
 	cli.OutputOpts
-	store  PrivateEndpointCreator
-	region string
+	store              PrivateEndpointCreator
+	region             string
+	portMappingEnabled bool
 }
 
 func (opts *CreateOpts) initStore(ctx context.Context) func() error {
@@ -64,13 +65,14 @@ func (opts *CreateOpts) Run() error {
 
 func (opts *CreateOpts) newPrivateEndpointConnection() *atlasv2.CloudProviderEndpointServiceRequest {
 	createRequest := &atlasv2.CloudProviderEndpointServiceRequest{
-		Region:       opts.region,
-		ProviderName: provider,
+		Region:             opts.region,
+		ProviderName:       provider,
+		PortMappingEnabled: &opts.portMappingEnabled,
 	}
 	return createRequest
 }
 
-// atlas privateEndpoints gcp create --region region [--projectId projectId].
+// atlas privateEndpoints gcp create --region region [--portMappingEnabled] [--projectId projectId].
 func CreateBuilder() *cobra.Command {
 	opts := &CreateOpts{}
 	cmd := &cobra.Command{
@@ -81,7 +83,7 @@ func CreateBuilder() *cobra.Command {
 		Annotations: map[string]string{
 			"output": createTemplate,
 		},
-		Example: `  atlas privateEndpoints gcp create --region CENTRAL_US`,
+		Example: `  atlas privateEndpoints gcp create --region CENTRAL_US --portMappingEnabled`,
 		PreRunE: func(cmd *cobra.Command, _ []string) error {
 			return opts.PreRunE(
 				opts.ValidateProjectID,
@@ -94,6 +96,7 @@ func CreateBuilder() *cobra.Command {
 		},
 	}
 	cmd.Flags().StringVar(&opts.region, flag.Region, "", usage.PrivateEndpointRegion)
+	cmd.Flags().BoolVar(&opts.portMappingEnabled, flag.PortMappingEnabled, false, usage.PortMappingEnabled)
 
 	opts.AddProjectOptsFlags(cmd)
 	opts.AddOutputOptFlags(cmd)

internal/cli/privateendpoints/gcp/create_test.go

@@ -44,3 +44,44 @@ func TestCreate_Run(t *testing.T) {
 
 	test.VerifyOutputTemplate(t, createTemplate, expected)
 }
+
+func TestCreate_Run_WithPortMappingEnabled(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	mockStore := NewMockPrivateEndpointCreator(ctrl)
+
+	createOpts := &CreateOpts{
+		store:              mockStore,
+		region:             "region",
+		portMappingEnabled: true,
+	}
+
+	expected := &atlasv2.EndpointService{}
+	mockStore.
+		EXPECT().
+		CreatePrivateEndpoint(createOpts.ProjectID, createOpts.newPrivateEndpointConnection()).
+		Return(expected, nil).
+		Times(1)
+
+	err := createOpts.Run()
+	require.NoError(t, err)
+
+	// Verify that portMappingEnabled is set correctly in the request
+	req := createOpts.newPrivateEndpointConnection()
+	require.NotNil(t, req.PortMappingEnabled)
+	require.True(t, *req.PortMappingEnabled)
+
+	test.VerifyOutputTemplate(t, createTemplate, expected)
+}
+
+func TestCreate_Run_PortMappingEnabledDefaultFalse(t *testing.T) {
+	createOpts := &CreateOpts{
+		region: "region",
+	}
+
+	// Verify that portMappingEnabled defaults to false when not specified
+	require.False(t, createOpts.portMappingEnabled)
+
+	req := createOpts.newPrivateEndpointConnection()
+	require.NotNil(t, req.PortMappingEnabled)
+	require.False(t, *req.PortMappingEnabled)
+}

internal/cli/privateendpoints/gcp/describe.go

@@ -27,9 +27,8 @@ import (
 	atlasv2 "go.mongodb.org/atlas-sdk/v20250312014/admin"
 )
 
-var describeTemplate = `ID	GROUP NAME	REGION	STATUS	ERROR{{if .EndpointGroupNames}}{{range valueOrEmptySlice .EndpointGroupNames}}
-{{$.Id}}	{{.}}	{{$.RegionName}}	{{$.Status}}	{{$.ErrorMessage}}{{end}}{{else}}
-{{$.Id}}	N/A	{{$.RegionName}}	{{$.Status}}	{{$.ErrorMessage}}{{end}}
+var describeTemplate = `ID	GROUP NAME	REGION	STATUS	PORT MAPPING ENABLED	ERROR
+{{.Id}}	{{if and .EndpointGroupNames (gt (len .EndpointGroupNames) 0)}}{{range $i, $g := .EndpointGroupNames}}{{if $i}}, {{end}}{{$g}}{{end}}{{else}}N/A{{end}}	{{.RegionName}}	{{.Status}}	{{.PortMappingEnabled}}	{{.ErrorMessage}}
 `
 
 //go:generate go tool go.uber.org/mock/mockgen -typed -destination=describe_mock_test.go -package=gcp . PrivateEndpointDescriber

internal/flag/flags.go

@@ -170,6 +170,7 @@ const (
 	PrivateEndpointID                             = "privateEndpointId"                             // PrivateEndpointID flag
 	EndpointServiceID                             = "endpointServiceId"                             // EndpointServiceId flag
 	PrivateEndpointIPAddress                      = "privateEndpointIpAddress"                      // PrivateEndpointIPAddress flag
+	PortMappingEnabled                            = "portMappingEnabled"                            // PortMappingEnabled flag
 	Endpoint                                      = "endpoint"                                      // Endpoint flag
 	Retention                                     = "retention"                                     // Retention flag
 	AtlasCIDRBlock                                = "atlasCidrBlock"                                // AtlasCIDRBlock flag

internal/usage/usage.go

@@ -84,6 +84,7 @@ dbName and collection are required only for built-in roles.`
 	DataLakeTestBucket                            = "Name of an Amazon S3 data bucket that Atlas Data Federation uses to validate the provided role."
 	PrivateEndpointRegion                         = "Cloud provider region in which you want to create the private endpoint connection. For a complete list of supported AWS regions, see: https://dochub.mongodb.org/core/aws-atlas. For a complete list of supported Azure regions, see: https://dochub.mongodb.org/core/azure-atlas. For a complete list of supported GCP regions, see: https://dochub.mongodb.org/core/gcp-atlas."
 	PrivateEndpointProvider                       = "Name of the cloud provider you want to create the private endpoint connection for."
+	PortMappingEnabled                            = "Flag that indicates whether this endpoint service uses PSC port-mapping. This is only applicable for GCP Private Endpoint Services."
 	Comment                                       = "Optional description or comment for the entry."
 	AccessListsDeleteAfter                        = "ISO-8601-formatted UTC date after which Atlas removes the entry from the access list."
 	BDUsersDeleteAfter                            = "Timestamp in ISO 8601 in UTC after which Atlas deletes the user."