Revert "Add LDAP support to AtlasDatabaseUser (#2334)" (#2335)

This reverts commit 5464c18.

Author: s-urbaniak

api/v1/atlasdatabaseuser_types.go

@@ -110,13 +110,6 @@ type AtlasDatabaseUserSpec struct {
 	// +kubebuilder:validation:Enum:=NONE;MANAGED;CUSTOMER
 	// +optional
 	X509Type string `json:"x509Type,omitempty"`
-
-	// Part of the Lightweight Directory Access Protocol (LDAP) record that
-	// the database uses to authenticate this database user on the LDAP host.
-	// +kubebuilder:default:=NONE
-	// +kubebuilder:validation:Enum:=NONE;GROUP;USER
-	// +optional
-	LDAPAuthType string `json:"ldapAuthType,omitempty"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

config/crd/bases/atlas.mongodb.com_atlasdatabaseusers.yaml

@@ -120,16 +120,6 @@ spec:
                   - value
                   type: object
                 type: array
-              ldapAuthType:
-                default: NONE
-                description: |-
-                  Part of the Lightweight Directory Access Protocol (LDAP) record that
-                  the database uses to authenticate this database user on the LDAP host.
-                enum:
-                - NONE
-                - GROUP
-                - USER
-                type: string
               oidcAuthType:
                 default: NONE
                 description: |-

internal/controller/atlasdatabaseuser/databaseuser_test.go

@@ -2116,7 +2116,6 @@ func TestHasChanged(t *testing.T) {
 					OIDCAuthType: "NONE",
 					AWSIAMType:   "NONE",
 					X509Type:     "NONE",
-					LDAPAuthType: "NONE",
 				},
 				ProjectID: "project-id",
 			},
@@ -2127,7 +2126,6 @@ func TestHasChanged(t *testing.T) {
 					OIDCAuthType: "NONE",
 					AWSIAMType:   "NONE",
 					X509Type:     "NONE",
-					LDAPAuthType: "NONE",
 				},
 				ProjectID: "project-id",
 			},
@@ -2143,7 +2141,6 @@ func TestHasChanged(t *testing.T) {
 					OIDCAuthType: "NONE",
 					AWSIAMType:   "NONE",
 					X509Type:     "MANAGED",
-					LDAPAuthType: "NONE",
 				},
 				ProjectID: "project-id",
 			},
@@ -2154,7 +2151,6 @@ func TestHasChanged(t *testing.T) {
 					OIDCAuthType: "NONE",
 					AWSIAMType:   "NONE",
 					X509Type:     "NONE",
-					LDAPAuthType: "NONE",
 				},
 				ProjectID: "project-id",
 			},
@@ -2170,7 +2166,6 @@ func TestHasChanged(t *testing.T) {
 					OIDCAuthType: "NONE",
 					AWSIAMType:   "NONE",
 					X509Type:     "NONE",
-					LDAPAuthType: "NONE",
 				},
 				ProjectID: "project-id",
 			},
@@ -2181,7 +2176,6 @@ func TestHasChanged(t *testing.T) {
 					OIDCAuthType: "NONE",
 					AWSIAMType:   "NONE",
 					X509Type:     "NONE",
-					LDAPAuthType: "NONE",
 				},
 				ProjectID: "project-id",
 			},

internal/translation/dbuser/conversion.go

@@ -133,7 +133,6 @@ func fromAtlas(dbUser *admin.CloudDatabaseUser) (*User, error) {
 			OIDCAuthType:    dbUser.GetOidcAuthType(),
 			AWSIAMType:      dbUser.GetAwsIAMType(),
 			X509Type:        dbUser.GetX509Type(),
-			LDAPAuthType:    dbUser.GetLdapAuthType(),
 		},
 	}
 	if err := normalize(u.AtlasDatabaseUserSpec); err != nil {
@@ -162,7 +161,6 @@ func toAtlas(au *User) (*admin.CloudDatabaseUser, error) {
 		Username:        au.Username,
 		Password:        pointer.MakePtrOrNil(au.Password),
 		OidcAuthType:    pointer.MakePtrOrNil(au.OIDCAuthType),
-		LdapAuthType:    pointer.MakePtrOrNil(au.LDAPAuthType),
 	}, nil
 }
 

internal/translation/dbuser/conversion_test.go

@@ -272,7 +272,6 @@ func TestDiffSpecs(t *testing.T) {
 					spec.OIDCAuthType = "IDP_GROUP"
 					spec.AWSIAMType = "USER"
 					spec.X509Type = "MANAGED"
-					spec.LDAPAuthType = "GROUP"
 					return spec
 				}(),
 			},
@@ -283,7 +282,6 @@ func TestDiffSpecs(t *testing.T) {
 				"oidcAuthType",
 				"awsIamType",
 				"x509Type",
-				"ldapAuthType",
 			},
 		},