Skip to content

Commit 8bf3c1a

Browse files
authored
Move shellcheck config to dedicated rc file (#825)
# Summary This allows invoking ShellCheck outside of the pre-commit hook, [such as in the VSCode linter extension](https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck). ## Proof of Work <!-- Enter your proof that it works here.--> ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details Signed-off-by: Yavor Georgiev <yavor.georgiev@mongodb.com>
1 parent 37c4a41 commit 8bf3c1a

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.pre-commit-config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ repos:
117117
rev: v0.10.0
118118
hooks:
119119
- id: shellcheck
120-
args: [-e, SC2154, -e, SC2153, -e, SC1091, -e, SC1090, -e, SC2148, -o, require-variable-braces, -P, scripts]
121120
exclude: |
122121
(?x)^(
123122
vendor/.*|

.shellcheckrc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Disable specific checks
2+
disable=SC2154,SC2153,SC1091,SC1090,SC2148
3+
4+
# Enable optional checks
5+
enable=require-variable-braces
6+
7+
# Add scripts directory to source path
8+
source-path=scripts

0 commit comments

Comments
 (0)