ai code review

Author: siquanlv

.github/scripts/ai_code_reviewer.py

@@ -116,22 +116,42 @@ def get_llm_response(prompt, api_key, model_name="gpt-4o"): # 或 "gemini-pro"
     llm_api_key = os.environ.get('LLM_API_KEY') # 统一使用 LLM_API_KEY 环境变量
     llm_model_name = os.environ.get('LLM_MODEL_NAME', 'gpt-4o') # 默认为 gpt-4o
 
+    # <-- 新增的调试输出 -->
+    print(f"--- Python Script Init Debug ---")
+    print(f"Read GITHUB_BASE_REF: {base_ref}")
+    print(f"Read GITHUB_HEAD_REF: {head_ref}")
+    print(f"Read GITHUB_PR_NUMBER: {pull_request_number}")
+    print(f"Read GITHUB_REPOSITORY: {repo_name}")
+    print(f"LLM_API_KEY is {'present' if llm_api_key else 'MISSING'}")
+    print(f"--- End Python Script Init Debug ---")
+    # <-- 结束新增的调试输出 -->
+
     if not all([base_ref, head_ref, pull_request_number, repo_name, llm_api_key]):
         print("Missing required environment variables.")
+        # 更详细的缺失信息
+        missing_vars = []
+        if not base_ref: missing_vars.append("GITHUB_BASE_REF")
+        if not head_ref: missing_vars.append("GITHUB_HEAD_REF")
+        if not pull_request_number: missing_vars.append("GITHUB_PR_NUMBER")
+        if not repo_name: missing_vars.append("GITHUB_REPOSITORY")
+        if not llm_api_key: missing_vars.append("LLM_API_KEY")
+        print(f"Specifically missing: {', '.join(missing_vars)}")
         sys.exit(1)
 
     print(f"Reviewing PR #{pull_request_number} for {repo_name}...")
     print(f"Base Ref: {base_ref}, Head Ref: {head_ref}")
 
     # 切换到 base_ref 以便正确获取 diff
-    subprocess.run(f"git fetch origin {base_ref}", shell=True, check=True)
-    subprocess.run(f"git checkout {base_ref}", shell=True, check=True)
+#     subprocess.run(f"git fetch origin {base_ref}", shell=True, check=True)
+#     subprocess.run(f"git checkout {base_ref}", shell=True, check=True)
 
     # 获取所有变更的 .java 文件路径
     changed_java_files_command = f"git diff --name-only {base_ref} {head_ref} | grep '\\.java$'"
+    print(f"Executing git diff command: {changed_java_files_command}") # <-- 新增调试：打印实际执行的命令
     changed_java_files = subprocess.check_output(changed_java_files_command, shell=True, text=True, encoding='utf-8').strip()
     changed_files_list = changed_java_files.split('\n') if changed_java_files else []
 
+
     if not changed_java_files:
         print("No Java files changed in this PR. Skipping AI review.")
         # 在 GitHub Actions 中，如果不想让这一步失败，可以 exit 0 或不输出任何内容

.github/workflows/ai_code_review.yml

@@ -3,41 +3,55 @@ name: AI Powered Code Review
 
 on:
   pull_request:
-    types: [opened, reopened, synchronize] # 当 PR 打开、重开或有新提交时触发
+    types: [opened, reopened, synchronize]
 
 jobs:
   ai_review:
-    runs-on: ubuntu-latest # 使用 Ubuntu 运行器
+    runs-on: ubuntu-latest
     permissions:
-      contents: read # 读取代码的权限
-      pull-requests: write # 在 PR 上发表评论的权限
+      contents: read
+      pull-requests: write
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
         with:
-          fetch-depth: 0 # 必须获取完整的历史，以便 git diff 正确工作
+          fetch-depth: 0
 
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.9' # 或者你喜欢的 Python 版本
+          python-version: '3.9'
 
       - name: Install Python Dependencies
-        run: pip install openai # 或者 google-generativeai，取决于你选择的 LLM
+        run: pip install openai
 
-      - name: Get Pull Request Details
+      - name: Get Pull Request Details and Set Env # 保持这一步，它将 SHA 设置为环境变量
         id: pr_details
         run: |
           echo "GITHUB_BASE_REF=${{ github.event.pull_request.base.sha }}" >> $GITHUB_ENV
           echo "GITHUB_HEAD_REF=${{ github.event.pull_request.head.sha }}" >> $GITHUB_ENV
           echo "GITHUB_PR_NUMBER=${{ github.event.pull_request.number }}" >> $GITHUB_ENV
           echo "GITHUB_REPOSITORY=${{ github.repository }}" >> $GITHUB_ENV
 
+      - name: **Debug Env Vars Before Python Script** # <-- 新增的调试步骤
+        run: |
+          echo "Current GITHUB_BASE_REF: $GITHUB_BASE_REF"
+          echo "Current GITHUB_HEAD_REF: $GITHUB_HEAD_REF"
+          echo "Current GITHUB_PR_NUMBER: $GITHUB_PR_NUMBER"
+          echo "Current GITHUB_REPOSITORY: $GITHUB_REPOSITORY"
+          echo "LLM_API_KEY is present: ${LLM_API_KEY:+true}" # 检查API key是否存在，不打印值
+        env:
+          LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }} # 需要在这里也传递，以便在此步骤中访问
+
       - name: Run AI Code Review
         run: python .github/scripts/ai_code_reviewer.py
         env:
-          LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }} # 或者 ${{ secrets.GEMINI_API_KEY }}
-          LLM_MODEL_NAME: gpt-4o # 或者 gemini-pro
-          # GITHUB_TOKEN 是 Actions 默认提供的，用于 API 交互，这里会被 gh cli 自动使用
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          LLM_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+          LLM_MODEL_NAME: gpt-4o
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          # 明确传递这些环境变量，确保Python脚本能获取到正确的值
+          GITHUB_BASE_REF: ${{ env.GITHUB_BASE_REF }}
+          GITHUB_HEAD_REF: ${{ env.GITHUB_HEAD_REF }}
+          GITHUB_PR_NUMBER: ${{ env.GITHUB_PR_NUMBER }}
+          GITHUB_REPOSITORY: ${{ env.GITHUB_REPOSITORY }}