impr: better handling of mongodb errors (@fehmer)

Author: fehmer

backend/src/middlewares/error.ts

@@ -46,9 +46,11 @@ async function errorHandlingMiddleware(
       uid: monkeyError.uid ?? req.ctx?.decodedToken?.uid,
     };
     let message = "Unknown error";
+    let isDbError = false;
 
     if (/ECONNREFUSED.*27017/i.test(error.message)) {
       message = "Could not connect to the database. It may be down.";
+      isDbError = true;
     } else if (error instanceof URIError || error instanceof SyntaxError) {
       status = 400;
       message = "Unprocessable request";
@@ -73,27 +75,30 @@ async function errorHandlingMiddleware(
         errorId: string;
       };
 
-      try {
-        await addLog(
-          "system_error",
-          `${status} ${errorId} ${error.message} ${error.stack}`,
-          uid
-        );
-        await db.collection<DBError>("errors").insertOne({
-          _id: errorId,
-          timestamp: Date.now(),
-          status: status,
-          uid,
-          message: error.message,
-          stack: error.stack,
-          endpoint: req.originalUrl,
-          method: req.method,
-          url: req.url,
-        });
-      } catch (e) {
-        Logger.error("Logging to db failed.");
-        Logger.error(getErrorMessage(e) ?? "Unknown error");
-        console.error(e);
+      if (!isDbError) {
+        try {
+          await addLog(
+            "system_error",
+            `${status} ${errorId} ${error.message} ${error.stack}`,
+            uid
+          );
+
+          await db.collection<DBError>("errors").insertOne({
+            _id: errorId,
+            timestamp: Date.now(),
+            status: status,
+            uid,
+            message: error.message,
+            stack: error.stack,
+            endpoint: req.originalUrl,
+            method: req.method,
+            url: req.url,
+          });
+        } catch (e) {
+          Logger.error("Logging to db failed.");
+          Logger.error(getErrorMessage(e) ?? "Unknown error");
+          console.error(e);
+        }
       }
     } else {
       Logger.error(`Error: ${error.message} Stack: ${error.stack}`);

backend/src/server.ts

@@ -17,13 +17,25 @@ import * as EmailClient from "./init/email-client";
 import { init as initFirebaseAdmin } from "./init/firebase-admin";
 import { createIndicies as leaderboardDbSetup } from "./dal/leaderboards";
 import { createIndicies as blocklistDbSetup } from "./dal/blocklist";
-import { createIndicies as connectionsDbSetup } from "./dal/connections";
 import { getErrorMessage } from "./utils/error";
+import { exit } from "process";
 
 async function bootServer(port: number): Promise<Server> {
   try {
     Logger.info(`Starting server version ${version}`);
     Logger.info(`Starting server in ${process.env["MODE"]} mode`);
+
+    process.on("unhandledRejection", (err) => {
+      const isDbError =
+        err instanceof Error && /ECONNREFUSED.*27017/i.test(err.message);
+      if (isDbError) {
+        Logger.error("Failed to connect to database, ignore error");
+      } else {
+        Logger.error("Unhandled rejection: " + getErrorMessage(err));
+        exit(-1);
+      }
+    });
+
     Logger.info(`Connecting to database ${process.env["DB_NAME"]}...`);
     await db.connect();
     Logger.success("Connected to database");
@@ -77,9 +89,6 @@ async function bootServer(port: number): Promise<Server> {
     Logger.info("Setting up blocklist indicies...");
     await blocklistDbSetup();
 
-    Logger.info("Setting up connections indicies...");
-    await connectionsDbSetup();
-
     recordServerVersion(version);
   } catch (error) {
     Logger.error("Failed to boot server");