-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
impr(input-history): Replace tabs and newlines with arrows in input history and replay (@Leonabcd123) #7136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Leonabcd123
wants to merge
12
commits into
monkeytypegame:master
Choose a base branch
from
Leonabcd123:add-tab-to-input-history
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
impr(input-history): Replace tabs and newlines with arrows in input history and replay (@Leonabcd123) #7136
Leonabcd123
wants to merge
12
commits into
monkeytypegame:master
from
Leonabcd123:add-tab-to-input-history
+47
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Screen.Recording.2025-11-26.at.23.15.06.movThis breaks the alignment when tabs or newlines were typed incorrectly. Also im not sure if i like the look to be fair. |
Contributor
Author
|
For the looks, I think anything will be better than just a blank, as currently if you have a test comprising of only tabs and/or newlines, the input history will be blank. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made tabs and newlines render as arrows in result history and in replay.