Skip to content

Conversation

@Miodec
Copy link
Member

@Miodec Miodec commented Nov 23, 2025

  • main linting is now done by oxlint. eslint remains for linting json files in the frontend (until oxlint adds support)
  • move type checking to the lint step (with --type-check)
    this improves performance by removing a duplicated typescript parse task (instead of parsing for linting then again for type checking, it parses once for both)
  • add a lint-fast npm script to get some fast fail behavior. it simply lints with no type information
  • oxc plugins are still in preview, so the custom plugin that checks for __testing usage outside of tests runs outside the main linting job until performance is improved
  • fixes some type issues (and config issues) that were not visible due to a missing type check on some files. now type checking will run on every file that is linted
  • split up oxc config for easier management

seeing around 3x improvement in type aware linting

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff packages Changes in local packages labels Nov 23, 2025
@socket-security
Copy link

socket-security bot commented Nov 23, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​eslint/​json@​0.14.010010010091100
Addedeslint@​9.39.19710010095100

View full report

@monkeytypegeorge monkeytypegeorge added the docs Related to Markdown files and documentation label Nov 23, 2025
@Miodec Miodec requested a review from fehmer November 23, 2025 23:56
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Nov 23, 2025
@thesomewhatyou
Copy link
Contributor

this was a pro gram move anyway i love oxc

@Miodec Miodec changed the title chore: replace eslint with oxc --type-aware (@miodec) chore: oxc --type-aware --type-check (@miodec) Dec 2, 2025
fehmer
fehmer previously approved these changes Dec 3, 2025
.eslintignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still in use? you added ignorePatterns to the oxlint config files

@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Dec 3, 2025
@monkeytypegeorge monkeytypegeorge removed the docs Related to Markdown files and documentation label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Server stuff frontend User interface or web stuff packages Changes in local packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants