fix(custom-text): Don't trim custom text (@Leonabcd123) #7170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Whats the reason for this change? |
Contributor
Author
|
Mainly to make sure that no matter what the custom text is, it will always stay the same when you click on "change" and then "ok". The current problem is that leading and trailing tabs and newlines will be removed when you click on "change" and "ok" for the second time (because they're now in their literal form, not \t and \n). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the
.trim()call that deleted leading and trailing literal tabs or newlines from custom text.This is to make sure that no matter what the custom text is, it will always stay the same after updating it. The current problem is that leading and trailing tabs and newlines will be removed when you click on "change" and "ok" for the second time (because they're now in their literal form, not \t and \n).