Skip to content

Conversation

@Leonabcd123
Copy link
Contributor

Description

Save lazy mode status in local storage after getting the "This language does not support lazy mode" message. This is so the user doesn't get the same message every time they refresh, and it matches up with the settings that show that lazy mode is disabled even though it's enabled in local storage.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 28, 2025
@Leonabcd123
Copy link
Contributor Author

The other times that we update lazy mode do seem to be intentionally temporarily, so I didn't change it for them. Might need to reconsider this (for example, if you enable lazy mode while language is english, you will get the not supported message, then when you switch to a supported language, it will enable lazy mode, but after your refresh it will go away).

@Leonabcd123 Leonabcd123 changed the title fix(lazy-mode): Save lazy mode in local storage (@Leonabcd123) fix(lazy-mode): Save lazy mode in local storage after getting not supported message (@Leonabcd123) Nov 28, 2025
@Miodec
Copy link
Member

Miodec commented Dec 4, 2025

The issue with this approach is if you switch between a language that supports lazy mode and a language that doesn't, you will need to reenable lazy mode every time.

@Leonabcd123
Copy link
Contributor Author

Leonabcd123 commented Dec 5, 2025

33c3bf1 makes sure that we don't set rememberLazyMode to false after we show the not supported message. Note that if you refresh after the notification and then switch to a supported language, lazy mode will not be enabled (which I'm not sure if we want it like this or not).

In all other cases (just switching between a supported and a not supported language), this will correctly enable and disable lazy mode automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants