Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-/ key binding does not work #95

Open
adrianfon9 opened this issue Jun 2, 2018 · 6 comments
Open

cmd-/ key binding does not work #95

adrianfon9 opened this issue Jun 2, 2018 · 6 comments
Labels
bug help wanted Extra attention is needed

Comments

@adrianfon9
Copy link

key binding in default (ace) does not function as comment toggle in the default (ace) editor even with focus within editing window.

@pq pq added the bug label Jun 2, 2018
@pq
Copy link
Collaborator

pq commented Jun 2, 2018

added context from lines:

I am using safari 11.1.1 on 10.13.5

@pq pq added the help wanted Extra attention is needed label Jun 10, 2018
@dansimco
Copy link
Contributor

dansimco commented Oct 2, 2018

Just confirming this is still an issue? Can't replicate it myself. I'm looking into implementing some keyboard shortcuts at the moment and thought I'd take a swing past this issue while looking at keybinds.

@pq
Copy link
Collaborator

pq commented Oct 2, 2018

hiya @dansimco . i haven't cycled back to this but would be pretty surprised if it weren't still in an issue. browser quirks. 😬

or wait, are you on os x? and using safari? what versions?

what kinds of refinements did you have in mind?

@synthetiv
Copy link
Contributor

I'm on Mac OS Mojave version 10.14.6, Safari 12.1.2, and Cmd-/ works fine for me when editing Lua files. It does NOT work on SuperCollider files, in either Safari, Chrome, or Firefox, but I'm sure that's because Ace doesn't know enough about SC to know what a line comment would look like, and I know there's another issue here for that.

If this is still an issue for the OP, it might be a conflict with a browser extension.

@dansimco
Copy link
Contributor

As a workaround to a few quirks like this, I can recommend using https://fluidapp.com/ on Mac to make yourself a "Maiden" app. For one it saves me from accidentally backing-out of the page when pressing cmd+[ . Maiden also looks really nice in it's own app.

@synthetiv
Copy link
Contributor

Good point! Nativefier is a solid open source option for this. More fiddly to configure, but you can even set up an app to be frameless (no titlebar). I haven't been using maiden long enough to do this yet, but I'm sure I will eventually...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants