Skip to content

Commit 31cf889

Browse files
committed
Revert "fix(lint): replace HLint suppressions with the actual fixes where safe"
This reverts commit 76076a1.
1 parent 76076a1 commit 31cf889

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/Pages/Replay.hs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -577,12 +577,6 @@ maxFilesPerMerge = 25
577577
-- | Upload the events for one replay message. Takes the events sub-tree as
578578
-- raw JSON bytes (already validated as a JSON value by the splitter) and
579579
-- streams them straight into MinIO with no AE.encode round-trip.
580-
--
581-
-- The HLint "Use alternative" hint suggests dropping the @BL.@ qualifier
582-
-- on @BL.fromStrict@. That is wrong here: Relude's unqualified
583-
-- @fromStrict@ is @Data.Text.Lazy.fromStrict :: Text -> LText@, not
584-
-- @Data.ByteString.Lazy.fromStrict :: ByteString -> LByteString@, so the
585-
-- naive refactor breaks the build. Keep the qualifier; suppress the hint.
586580
{-# ANN saveReplayMinio ("HLint: ignore Use alternative" :: String) #-}
587581
saveReplayMinio :: (DB es, Log :> es, Time :> es) => EnvConfig -> Pool Connection -> Text -> ReplayPayload -> Eff es (Maybe Text)
588582
saveReplayMinio envCfg jobsPool ackId payload = do

src/Pkg/EmailTemplates.hs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,8 @@ logPatternRateChangeEmail projectName issueUrl patternText logLevel serviceName
450450

451451
-- | Summary digest body for the hourly notification flush (rate-limited
452452
-- overflow + low-signal issues). Subject is built at the call site.
453+
{-# ANN digestEmail ("HLint: ignore Use 'unlines' from Relude" :: String) #-}
454+
{-# ANN digestEmail ("HLint: ignore Use 'lines' from Relude" :: String) #-}
453455
digestEmail :: Text -> Text -> Text -> Int -> Html ()
454456
digestEmail projectName inboxUrl summary total = emailBody do
455457
h1_ "Batched notifications"
@@ -462,8 +464,8 @@ digestEmail projectName inboxUrl summary total = emailBody do
462464
emailDivider
463465
pre_ [style_ "font-family: monospace; font-size: 13px; white-space: pre-wrap; margin: 0 0 16px 0;"]
464466
$ toHtml
465-
$ unlines
466-
$ map stripSummaryBadges (lines summary)
467+
$ T.unlines
468+
$ map stripSummaryBadges (T.lines summary)
467469
emailButton inboxUrl "Open inbox"
468470

469471

src/Web/ApiHandlers.hs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1134,6 +1134,7 @@ apiMemberRemove pid uid = do
11341134
-- The response is always a JSON object keyed by field path, each value a
11351135
-- @[{value, count}]@ list sorted by count descending. Missing/expired
11361136
-- facets return @{}@ (not 404) — agents can rely on the shape regardless.
1137+
{-# ANN apiFacets ("HLint: ignore Use id" :: String) #-}
11371138
apiFacets :: Projects.ProjectId -> Maybe Text -> Maybe Text -> Maybe Text -> Maybe Text -> ATBaseCtx AE.Value
11381139
apiFacets pid sinceM fromM toM fieldM = do
11391140
now <- Time.currentTime
@@ -1146,7 +1147,7 @@ apiFacets pid sinceM fromM toM fieldM = do
11461147
-- `resource___service___name`); the public API contract is dotted.
11471148
dotKey = AEK.fromText . T.replace "___" "." . AEK.toText
11481149
asAeson = case AE.toJSON facetMap of
1149-
AE.Object o -> AE.Object (AEKM.mapKeyVal dotKey id o)
1150+
AE.Object o -> AE.Object (AEKM.mapKeyVal dotKey (\x -> x) o)
11501151
v -> v
11511152
filtered = case (fieldM, asAeson) of
11521153
(Just f, AE.Object o) ->

0 commit comments

Comments
 (0)