Merge pull request #73 from maximehuran/feature/few-changes

maximehuran · web-flow · commit 79606f41e00d · 2024-08-27T14:09:27.000+02:00
Change docker composer and reduce PHP Stan level
diff --git a/Makefile b/Makefile
@@ -9,7 +9,7 @@ export COMPOSE_PROJECT_NAME=cms-page
 export MIGRATIONS_NAMESPACE=MonsieurBiz\\SyliusCmsPagePlugin\\Migrations
 export USER_UID=$(shell id -u)
 PLUGIN_NAME=sylius-${COMPOSE_PROJECT_NAME}-plugin
-COMPOSE=docker-compose
+COMPOSE=docker compose
 YARN=yarn
 
 ###
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,5 @@
 parameters:
-    level: max
+    level: 8
     paths:
         - %rootDir%/src/
 
diff --git a/src/Repository/PageRepository.php b/src/Repository/PageRepository.php
@@ -40,7 +40,6 @@ public function existsOneByChannelAndSlug(ChannelInterface $channel, ?string $lo
             ;
         }
 
-        /** @phpstan-ignore-next-line */
         $count = (int) $queryBuilder
             ->getQuery()
             ->getSingleScalarResult()
@@ -56,7 +55,6 @@ public function existsOneEnabledByChannelAndSlug(ChannelInterface $channel, ?str
             ->andWhere('p.enabled = true')
         ;
 
-        /** @phpstan-ignore-next-line */
         $count = (int) $queryBuilder
             ->getQuery()
             ->getSingleScalarResult()
@@ -70,7 +68,6 @@ public function existsOneEnabledByChannelAndSlug(ChannelInterface $channel, ?str
      */
     public function findOneEnabledBySlugAndChannelCode(string $slug, string $localeCode, string $channelCode): ?PageInterface
     {
-        /** @phpstan-ignore-next-line */
         return $this->createQueryBuilder('p')
             ->leftJoin('p.translations', 'translation')
             ->innerJoin('p.channels', 'channels')

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@ public function existsOneByChannelAndSlug(ChannelInterface $channel, ?string $lo`
`40`	`40`	`;`
`41`	`41`	`}`
`42`	`42`
`43`		`- /** @phpstan-ignore-next-line */`
`44`	`43`	`$count = (int) $queryBuilder`
`45`	`44`	`->getQuery()`
`46`	`45`	`->getSingleScalarResult()`
`@@ -56,7 +55,6 @@ public function existsOneEnabledByChannelAndSlug(ChannelInterface $channel, ?str`
`56`	`55`	`->andWhere('p.enabled = true')`
`57`	`56`	`;`
`58`	`57`
`59`		`- /** @phpstan-ignore-next-line */`
`60`	`58`	`$count = (int) $queryBuilder`
`61`	`59`	`->getQuery()`
`62`	`60`	`->getSingleScalarResult()`
`@@ -70,7 +68,6 @@ public function existsOneEnabledByChannelAndSlug(ChannelInterface $channel, ?str`
`70`	`68`	`*/`
`71`	`69`	`public function findOneEnabledBySlugAndChannelCode(string $slug, string $localeCode, string $channelCode): ?PageInterface`
`72`	`70`	`{`
`73`		`- /** @phpstan-ignore-next-line */`
`74`	`71`	`return $this->createQueryBuilder('p')`
`75`	`72`	`->leftJoin('p.translations', 'translation')`
`76`	`73`	`->innerJoin('p.channels', 'channels')`