feat: add message on constraint and prefill name with customer fullname

Author: Maxime Leclercq

src/Form/Extension/ContactTypeExtension.php

@@ -15,17 +15,21 @@
 
 use MonsieurBiz\SyliusSettingsPlugin\Provider\SettingsProviderInterface;
 use Sylius\Bundle\CoreBundle\Form\Type\ContactType;
+use Sylius\Component\Customer\Context\CustomerContextInterface;
 use Symfony\Component\Form\AbstractTypeExtension;
 use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
 use Symfony\Component\Form\Extension\Core\Type\TelType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormBuilderInterface;
+use Symfony\Component\Form\FormEvent;
+use Symfony\Component\Form\FormEvents;
 use Symfony\Component\Validator\Constraints as Assert;
 
 final class ContactTypeExtension extends AbstractTypeExtension
 {
     public function __construct(
         private SettingsProviderInterface $settingProvider,
+        private CustomerContextInterface $customerContext,
     ) {
     }
 
@@ -36,15 +40,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         parent::buildForm($builder, $options);
 
-        $defaultConstraints = [
-            new Assert\Length(['max' => 255]),
-        ];
-
-        $requiredConstraints = [
-            new Assert\NotBlank(),
-            new Assert\Length(['max' => 255]),
-        ];
-
         $isNameRequired = $this->isFieldRequired('field_name_required', 'field_name_displayed');
         $isCompanyRequired = $this->isFieldRequired('field_company_required', 'field_company_displayed');
         $isPhoneNumberRequired = $this->isFieldRequired('field_phone_number_required', 'field_phone_number_displayed');
@@ -53,17 +48,18 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             ->add('name', TextType::class, [
                 'label' => 'monsieurbiz.contact_request.form.name',
                 'required' => $isNameRequired,
-                'constraints' => $isNameRequired ? $requiredConstraints : $defaultConstraints,
+                'constraints' => $this->getConstraints($isNameRequired, 'monsieurbiz.contact_request.name.not_blank'),
             ])
             ->add('company', TextType::class, [
                 'label' => 'monsieurbiz.contact_request.form.company',
                 'required' => $isCompanyRequired,
-                'constraints' => $isCompanyRequired ? $requiredConstraints : $defaultConstraints,
+                'constraints' => $this->getConstraints($isCompanyRequired, 'monsieurbiz.contact_request.company.not_blank'),
             ])
             ->add('phoneNumber', TelType::class, [
                 'label' => 'monsieurbiz.contact_request.form.phone_number',
+                'invalid_message' => 'monsieurbiz.contact_request.phone_number.invalid',
                 'required' => $isPhoneNumberRequired,
-                'constraints' => $isPhoneNumberRequired ? $requiredConstraints : $defaultConstraints,
+                'constraints' => $this->getConstraints($isPhoneNumberRequired, 'monsieurbiz.contact_request.phone_number.not_blank'),
             ])
         ;
 
@@ -82,6 +78,19 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 ],
             ]);
         }
+
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event): void {
+            $name = $this->customerContext->getCustomer()?->getFullName();
+            if (null === $name) {
+                return;
+            }
+
+            /** @var array $data */
+            $data = $event->getData();
+            $data['name'] = $name;
+
+            $event->setData($data);
+        });
     }
 
     public static function getExtendedTypes(): iterable
@@ -96,4 +105,16 @@ private function isFieldRequired(string $path, string $pathDisplayed): bool
         return $this->settingProvider->getSettingValue('monsieurbiz_contact_request.contact', $path)
             && $this->settingProvider->getSettingValue('monsieurbiz_contact_request.contact', $pathDisplayed);
     }
+
+    private function getConstraints(bool $isRequired, ?string $blankMessage): array
+    {
+        return $isRequired ? [
+            new Assert\NotBlank([
+                'message' => $blankMessage,
+            ]),
+            new Assert\Length(['max' => 255]),
+        ] : [
+            new Assert\Length(['max' => 255]),
+        ];
+    }
 }

src/Resources/translations/validators.en.yaml

@@ -1,3 +1,10 @@
-monsieurbiz:
+ monsieurbiz:
     contact_request:
         confirmation_error: 'You need to approve this field'
+        name:
+            not_blank: Please enter your name
+        company:
+            not_blank: Please enter your company name
+        phone_number:
+            invalid: Please enter a valid phone number
+            not_blank: Please enter your phone number

src/Resources/translations/validators.fr.yaml

@@ -1,3 +1,10 @@
 monsieurbiz:
     contact_request:
         confirmation_error: 'Vous devez approuver ce champ'
+        name:
+            not_blank: Veuillez entrer votre nom
+        company:
+            not_blank: Veuillez entrer le nom de votre société
+        phone_number:
+            invalid: Veuillez entrer un numéro de téléphone valide
+            not_blank: Veuillez entrer votre numéro de téléphone