[error] - monsieurbiz_search_search with POST empty throw 500 #201
Description
Hi ,
Facing an issue when a user post an empty search or try to discover some 500 on app
To reproduce
curl -I -XPOST http://127.0.0.1/fr_FR/search
HTTP/1.1 500 Internal Server Error
Server: nginx/1.21.6
... public function postAction(Request $request): RedirectResponse
{
$query = (array) $request->request->all()['monsieurbiz_searchplugin_search'] ?? [];
$query = $query['query'] ?? '';
return $this->redirect(
$this->generateUrl(
'monsieurbiz_search_search',
['query' => urlencode($query)]
)
);
}if query param no exist, an empty string is assigned $query but route monsieurbiz_search_search required 1 char minimum
https://github.com/monsieurbiz/SyliusSearchPlugin/blob/master/src/Resources/config/routing/shop.yaml#L7
monsieurbiz_search_search:
path: /search/{query}
methods: [GET]
defaults:
_controller: MonsieurBiz\SyliusSearchPlugin\Controller\SearchController::searchAction
requirements:
query: .+
condition: "not(context.getPathInfo() matches '`^%sylius.security.new_api_route%`') and context.checkElasticsearch()"a possible solution will be to authorize 0 to n char
monsieurbiz_search_search:
path: /search/{query}
methods: [GET]
defaults:
_controller: MonsieurBiz\SyliusSearchPlugin\Controller\SearchController::searchAction
requirements:
query: .*
condition: "not(context.getPathInfo() matches '`^%sylius.security.new_api_route%`') and context.checkElasticsearch()"