Merge pull request #54 from monzo/fix-initialisation-of-is-unexpected-flag

Stop initialising the IsUnexpected flag to false for new errors

Author: tompreston

errors.go

@@ -218,7 +218,8 @@ func (p *Error) Retryable() bool {
 }
 
 // Unexpected states whether an error is not expected to occur. In many cases this will be due to a bug, e.g. due to a
-// defensive check failing
+// defensive check failing.
+// Note that if the IsUnexpected flag has not been set at all, this will still return false.
 func (p *Error) Unexpected() bool {
 	if p.IsUnexpected != nil {
 		return *p.IsUnexpected

errors_test.go

@@ -575,7 +575,7 @@ func TestSetIsRetryable(t *testing.T) {
 
 func TestSetIsUnexpected(t *testing.T) {
 	err := New("code", "message", nil)
-	assert.False(t, *err.IsUnexpected)
+	assert.Nil(t, err.IsUnexpected)
 
 	err.SetIsUnexpected(true)
 	assert.True(t, *err.IsUnexpected)

factory.go

@@ -117,10 +117,9 @@ func RateLimited(code, message string, params map[string]string) *Error {
 // Builds a stack based on the current call stack
 func errorFactory(code string, message string, params map[string]string) *Error {
 	err := &Error{
-		Code:         ErrUnknown,
-		Message:      message,
-		Params:       map[string]string{},
-		IsUnexpected: &notUnexpected,
+		Code:    ErrUnknown,
+		Message: message,
+		Params:  map[string]string{},
 	}
 	if len(code) > 0 {
 		err.Code = code