Skip to content

Commit 63066b6

Browse files
committed
Remove pixel_aspect_ratio
Old code for the non-square pixel issue on Touch 1. There was no solution for this in the new kms video core driver This frees up cfg_system param id 99 (RESERVED_99)
1 parent 81874f6 commit 63066b6

File tree

6 files changed

+3
-38
lines changed

6 files changed

+3
-38
lines changed

var/local/www/db/moode-sqlite3.db.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--
2-
-- File generated with SQLiteStudio v3.4.4 on Mon Nov 10 18:00:16 2025
2+
-- File generated with SQLiteStudio v3.4.4 on Wed Nov 12 07:19:41 2025
33
--
44
-- Text encoding used: UTF-8
55
--
@@ -629,7 +629,7 @@ INSERT INTO cfg_system (id, param, value) VALUES (95, 'rsmaftersl', 'No');
629629
INSERT INTO cfg_system (id, param, value) VALUES (96, 'mpdmixer_local', 'software');
630630
INSERT INTO cfg_system (id, param, value) VALUES (97, 'wrkready', '0');
631631
INSERT INTO cfg_system (id, param, value) VALUES (98, 'scnsaver_timeout', 'Never');
632-
INSERT INTO cfg_system (id, param, value) VALUES (99, 'pixel_aspect_ratio', 'Default');
632+
INSERT INTO cfg_system (id, param, value) VALUES (99, 'RESERVED_99', '');
633633
INSERT INTO cfg_system (id, param, value) VALUES (100, 'favorites_name', 'Favorites');
634634
INSERT INTO cfg_system (id, param, value) VALUES (101, 'spotifysvc', '0');
635635
INSERT INTO cfg_system (id, param, value) VALUES (102, 'spotifyname', 'Moode Spotify');

www/daemon/worker.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3570,9 +3570,6 @@ function runQueuedJob() {
35703570
case 'dsi_scn_brightness':
35713571
updDSIScnBrightness($_SESSION['dsi_scn_type'], $_SESSION['w_queueargs']);
35723572
break;
3573-
case 'pixel_aspect_ratio':
3574-
// NOTE: Touch1 (square pixels): no solution yet with the KMS driver
3575-
break;
35763573
case 'dsi_scn_rotate':
35773574
// touch1 value: 0 landscape | 180 inverted
35783575
// touch2 value 0 portrait | 90 | 180 | 270 landscape

www/inc/autocfg.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -674,12 +674,6 @@ function getCfgTableParams($table, $values, $prefix = '') {
674674
$_SESSION['dsi_scn_brightness'] = $values['dsi_scn_brightness'];
675675
updDSIScnBrightness($values['dsi_scn_type'], $values['dsi_scn_brightness']);
676676
}],
677-
// NOTE: Touch1 (square pixels): no solution yet with the KMS driver
678-
['requires' => ['pixel_aspect_ratio'], 'handler' => function($values) {
679-
phpSession('write', 'pixel_aspect_ratio', $values['pixel_aspect_ratio']);
680-
//$value = $values['pixel_aspect_ratio'] == 'Square' ? '' : '#';
681-
//updBootConfigTxt('upd_framebuffer_settings', $value);
682-
}],
683677
['requires' => ['dsi_scn_rotate'], 'handler' => function($values) {
684678
// touch1 value: 0 landscape | 180 inverted
685679
// touch2 value 0 portrait | 90 | 180 | 270 landscape

www/per-config.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -169,14 +169,6 @@
169169
}
170170
}
171171

172-
// NOTE: Touch1 (square pixels): no solution yet with the KMS driver
173-
/*if (isset($_POST['update_pixel_aspect_ratio'])) {
174-
if (isset($_POST['pixel_aspect_ratio']) && $_POST['pixel_aspect_ratio'] != $_SESSION['pixel_aspect_ratio']) {
175-
submitJob('pixel_aspect_ratio', $_POST['pixel_aspect_ratio'], NOTIFY_TITLE_INFO, NOTIFY_MSG_SYSTEM_RESTART_REQD);
176-
phpSession('write', 'pixel_aspect_ratio', $_POST['pixel_aspect_ratio']);
177-
}
178-
}*/
179-
180172
if (isset($_POST['update_dsi_scn_rotate'])) {
181173
if (isset($_POST['dsi_scn_rotate']) && $_POST['dsi_scn_rotate'] != $_SESSION['dsi_scn_rotate']) {
182174
phpSession('write', 'dsi_scn_rotate', $_POST['dsi_scn_rotate']);
@@ -345,10 +337,6 @@
345337
$_select['dsi_port'] .= "<option value=\"1\" " . (($_SESSION['dsi_port'] == '1') ? "selected" : "") . ">DSI-1</option>\n";
346338
$_select['dsi_port'] .= "<option value=\"2\" " . (($_SESSION['dsi_port'] == '2') ? "selected" : "") . ">DSI-2</option>\n";
347339

348-
// NOTE: Touch1 (square pixels): no solution yet with the KMS driver
349-
//$_select['pixel_aspect_ratio'] .= "<option value=\"Default\" " . (($_SESSION['pixel_aspect_ratio'] == 'Default') ? "selected" : "") . ">Default</option>\n";
350-
//$_select['pixel_aspect_ratio'] .= "<option value=\"Square\" " . (($_SESSION['pixel_aspect_ratio'] == 'Square') ? "selected" : "") . ">Square</option>\n";
351-
352340
$_select['dsi_scn_brightness'] = $_SESSION['dsi_scn_brightness'];
353341

354342
if ($_SESSION['dsi_scn_type'] == '1' || $_SESSION['dsi_scn_type'] == 'none') {

www/templates/per-config.html

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -236,19 +236,6 @@ <h1 class="per-config">Peripherals</h1>
236236
</span>
237237
</div>
238238

239-
<!-- Touch1: No solution with KMS driver as of r902 -->
240-
<!--label class="control-label" for="pixel-aspect-ratio">Pixel aspect ratio</label>
241-
<div class="controls">
242-
<select id="pixel-aspect-ratio" class="config-select-large" name="pixel_aspect_ratio" onchange="autoClick('#btn-set-pixel-aspect-ratio');" $_ctl_disable>
243-
$_select[pixel_aspect_ratio]
244-
</select>
245-
<button id="btn-set-pixel-aspect-ratio" class="hide btn btn-primary btn-small config-btn-set btn-submit" type="submit" name="update_pixel_aspect_ratio" value="novalue" $_ctl_disable><i class="fa fa-solid fa-sharp fa-arrow-turn-down-left"></i></button>
246-
<a aria-label="Help" class="config-info-toggle" data-cmd="info_pixel_aspect_ratio" href="#notarget"><i class="fa-regular fa-sharp fa-info-circle"></i></a>
247-
<span id="info_pixel_aspect_ratio" class="config-help-info">
248-
Rectangular (default) or square pixels for 7" Pi Touch.
249-
s</span>
250-
</div-->
251-
252239
<label class="control-label" for="dsi-scn-rotate">Rotate</label>
253240
<div class="controls">
254241
<select id="dsi-scn-rotate" class="config-select-large" name="dsi_scn_rotate" onchange="autoClick('#btn-set-dsi-scn-rotate');" $_dsi_ctl_disable>

www/util/sysinfo.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,6 @@ RENDERER_SETTINGS() {
396396
echo -e "\nDSI Screentype\t\t= $dsi_scn_type\c"
397397
echo -e "\nDSI Port\t\t= $dsi_port\c"
398398
echo -e "\nDSI Brightness\t\t= $dsi_scn_brightness\c"
399-
#echo -e "\nPixel aspect ratio\t= $pixel_aspect_ratio\c"
400399
echo -e "\nDSI Rotate\t\t= $dsi_scn_rotate Deg\n"
401400
fi
402401

@@ -809,7 +808,7 @@ rsmaftersl=${arr[94]}
809808
mpdmixer_local=${arr[95]}
810809
wrkready=${arr[96]}
811810
scnsaver_timeout=${arr[97]}
812-
pixel_aspect_ratio=${arr[98]}
811+
RESERVED_99=${arr[98]}
813812
favorites_name=${arr[99]}
814813
[[ "${arr[100]}" = "1" ]] && spotifysvc="On" || spotifysvc="Off"
815814
spotifyname=${arr[101]}

0 commit comments

Comments
 (0)