Skip to content

Commit 98301b3

Browse files
authored
Merge pull request #1073 from deXol/develop
Notes: Rename discard to Discard Changes and Exit, fix #1071
2 parents 7f3f851 + 7e30b7a commit 98301b3

3 files changed

Lines changed: 13 additions & 1 deletion

File tree

src/NotesManagement.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66

77
#include <QListWidget>
88

9+
const QString NotesManagement::EXIT_TEXT = tr("Exit");
10+
const QString NotesManagement::DISCARD_TEXT = tr("Discard Changes and Exit");
11+
912
NotesManagement::NotesManagement(QWidget *parent) :
1013
QWidget(parent),
1114
ui(new Ui::NotesManagement)
@@ -16,6 +19,8 @@ NotesManagement::NotesManagement(QWidget *parent) :
1619
ui->pushButtonSave->setStyleSheet(CSS_BLUE_BUTTON);
1720
ui->pushButtonDiscard->setStyleSheet(CSS_BLUE_BUTTON);
1821

22+
ui->pushButtonDiscard->setText(EXIT_TEXT);
23+
1924
ui->stackedWidget->setCurrentWidget(ui->pageListNotes);
2025
ui->scrollArea->setStyleSheet("QScrollArea { background-color:transparent; }");
2126
ui->scrollAreaWidgetContents->setStyleSheet("#scrollAreaWidgetContents { background-color:transparent; }");
@@ -190,6 +195,7 @@ void NotesManagement::on_pushButtonDiscard_clicked()
190195
m_isNewFile = false;
191196
m_isNoteEditing = false;
192197
emit updateTabs();
198+
ui->pushButtonDiscard->setText(EXIT_TEXT);
193199
}
194200

195201
void NotesManagement::on_pushButtonSave_clicked()
@@ -200,6 +206,7 @@ void NotesManagement::on_pushButtonSave_clicked()
200206
ui->stackedWidget->setCurrentWidget(ui->pageListNotes);
201207
ui->labelError->hide();
202208
m_isNoteEditing = false;
209+
ui->pushButtonDiscard->setText(EXIT_TEXT);
203210
}
204211

205212
void NotesManagement::on_toolButtonEditNote_clicked()
@@ -269,10 +276,12 @@ void NotesManagement::on_textEditNote_textChanged()
269276
if (note == m_noteContentClone || note.isEmpty() || (m_isNewFile && !m_validNoteName))
270277
{
271278
ui->pushButtonSave->hide();
279+
ui->pushButtonDiscard->setText(EXIT_TEXT);
272280
}
273281
else
274282
{
275283
ui->pushButtonSave->show();
284+
ui->pushButtonDiscard->setText(DISCARD_TEXT);
276285
}
277286
}
278287

src/NotesManagement.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ private slots:
6464
Ui::NotesManagement *ui;
6565

6666
WSClient *wsClient;
67+
68+
static const QString EXIT_TEXT;
69+
static const QString DISCARD_TEXT;
6770
};
6871

6972
#endif // NOTESMANAGEMENT_H

src/NotesManagement.ui

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ border-right: none;
237237
</size>
238238
</property>
239239
<property name="text">
240-
<string>Discard</string>
240+
<string>Exit</string>
241241
</property>
242242
</widget>
243243
</item>

0 commit comments

Comments
 (0)