refactor taint

Author: myfreess

rule/apply/apply.mbt

@@ -192,10 +192,11 @@ pub fn apply_taint_rules_to_impl(
   rules : Array[CompiledRule],
 ) -> Array[RuleFinding] raise {
   let hits : Array[RuleFinding] = []
+  let untyped_node = @untyped_ast.from_impl(node)
   for rule in rules {
     match rule.definition {
       Taint(taint_rule) =>
-        apply_taint_rule_to_impl(file, rule, taint_rule, node, hits)
+        apply_taint_rule_to_impl(file, rule, taint_rule, untyped_node, hits)
       _ => ()
     }
   }
@@ -207,7 +208,7 @@ fn apply_taint_rule_to_impl(
   file : String,
   rule : CompiledRule,
   taint_rule : CompiledTaintRule,
-  node : @syntax.Impl,
+  node : @untyped_ast.Node,
   hits : Array[RuleFinding],
 ) -> Unit raise {
   let spec = lower_compiled_taint_rule(rule, taint_rule)

rule/taint_lowering/moon.pkg

@@ -4,11 +4,9 @@ import {
   "moonbit-community/moongrep/untyped_ast",
   "moonbit-community/moongrep/taint",
   "moonbitlang/lexer/basic",
-  "moonbitlang/parser/syntax",
 }
 
 import {
   "moonbit-community/moongrep/rule/compile",
   "moonbitlang/parser",
-  "moonbitlang/parser/syntax",
 } for "wbtest"

rule/taint_lowering/taint_lowering.mbt

@@ -98,10 +98,9 @@ fn transfer_compiled_taint_call(
 ///|
 fn taint_pattern_matches(
   pattern : CompiledRulePattern,
-  expr : @syntax.Expr,
+  node : @untyped_ast.Node,
 ) -> Bool {
-  @matching.match_expr_pattern(pattern.compiled, @untyped_ast.from_expr(expr))
-  is Some(_)
+  @matching.match_expr_pattern(pattern.compiled, node) is Some(_)
 }
 
 ///|

rule/taint_lowering/taint_lowering_wbtest.mbt

@@ -2,15 +2,15 @@
 using @compile {compile_rules}
 
 ///|
-fn parse_single_taint_impl(source : String) -> @syntax.Impl raise {
+fn parse_single_taint_impl(source : String) -> @untyped_ast.Node raise {
   let (impls, reports) = @parser.parse_string(
     source,
     name="taint lowering test",
   )
   guard reports is [] else { fail("expected source to parse") }
   let nodes = impls.to_array()
   guard nodes is [node] else { fail("expected exactly one impl") }
-  node
+  @untyped_ast.from_impl(node)
 }
 
 ///|

taint/api.mbt

@@ -2,9 +2,9 @@
 /// Analyzes one function or method AST node using one taint specification.
 ///
 /// Raises `TaintAnalysisError::UnsupportedFunctionLike` when `node` is not a
-/// supported function-like parser implementation.
+/// supported function-like implementation node.
 pub fn analyze_function_like(
-  node : @syntax.Impl,
+  node : @untyped_ast.Node,
   spec : TaintSpec,
 ) -> AnalysisResult raise {
   analyze_single_function_like(node, spec)
@@ -15,7 +15,7 @@ pub fn analyze_function_like(
 ///
 /// Results are returned in the same order as `rules`.
 pub fn analyze_function_like_multi(
-  node : @syntax.Impl,
+  node : @untyped_ast.Node,
   rules : Array[TaintSpec],
 ) -> Array[AnalysisResult] raise {
   let results : Array[AnalysisResult] = []