Skip to content

Commit 8c95c88

Browse files
committed
refactor: replace local dependency for async with 0.20.4
1 parent 157c9b9 commit 8c95c88

9 files changed

Lines changed: 7 additions & 31 deletions

File tree

AGENTS.md

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -22,29 +22,6 @@ developer must perform them.
2222
- Never publish from an unverified dependency chain or use repository-local
2323
overrides for the final release smoke test.
2424

25-
### Active local override: `moonbitlang/async`
26-
27-
`moon.work` lists `../async` as a member, so every module resolves
28-
`moonbitlang/async` to a local checkout instead of the pinned registry version.
29-
That checkout is on the `external-loop-integration` branch, which adds
30-
`set_external_event_loop`. Proton needs it: AppKit owns the main thread, so
31-
before this Proton started a pthread and ran all application code there. With an
32-
external event loop every line of MoonBit stays on the main thread and only
33-
async's waiting half moves to a dedicated thread.
34-
35-
It is a workspace member rather than a per-module `moon.mod` override on
36-
purpose. Seven modules depend on async, and overriding only some of them would
37-
link two copies into one process, and therefore two event loops.
38-
39-
The branch still calls itself `0.20.3`, the same version published on mooncakes,
40-
so no version comparison can detect the substitution. `scripts/verify_release_metadata.mjs`
41-
therefore fails while any non-`./` member is present, and that script already
42-
runs in the publish workflow's validate step. Remove the member and re-pin to a
43-
published async before releasing.
44-
45-
Note that `moon fmt` strips comments from `moon.work`, which is why this
46-
explanation lives here instead of beside the member.
47-
4825
## Project Structure
4926
- `native/`: standalone CMake project for the Proton native runtime. It builds
5027
`proton` as a dynamic library/import library, installs `proton_native.h`, and

cdp/moon.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ version = "0.1.14"
55
readme = "README.mbt.md"
66

77
import {
8-
"moonbitlang/async@0.20.3",
8+
"moonbitlang/async@0.20.4",
99
"moonbitlang/x@0.4.48",
1010
}
1111

cli/moon.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
"moonbitlang/parser@0.3.2",
1111
"moonbitlang/moon_config@0.3.5",
1212
"moonbitlang/lexer@0.3.5",
13-
"moonbitlang/async@0.20.3",
13+
"moonbitlang/async@0.20.4",
1414
"moonbit-community/proton_ffi@0.1.14",
1515
}
1616

client/moon.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "moonbit-community/proton_client"
33
version = "0.1.14"
44

55
import {
6-
"moonbitlang/async@0.20.3",
6+
"moonbitlang/async@0.20.4",
77
"moonbit-community/proton_contract@0.1.14",
88
}
99

e2e/moon.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "moonbit-community/proton/e2e"
33
version = "0.1.14"
44

55
import {
6-
"moonbitlang/async@0.20.3",
6+
"moonbitlang/async@0.20.4",
77
"moonbitlang/x@0.4.48",
88
"moonbit-community/proton_cdp@0.1.14",
99
"moonbit-community/proton@0.1.14",

examples/moon.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version = "0.1.14"
44

55
import {
66
"moonbitlang/x@0.4.48",
7-
"moonbitlang/async@0.20.3",
7+
"moonbitlang/async@0.20.4",
88
"moonbit-community/proton_ext@0.1.14",
99
"moonbit-community/proton_contract@0.1.14",
1010
"moonbit-community/proton@0.1.14",

extensions/moon.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ version = "0.1.14"
55
import {
66
"moonbit-community/proton_ffi@0.1.14",
77
"moonbitlang/x@0.4.48",
8-
"moonbitlang/async@0.20.3",
8+
"moonbitlang/async@0.20.4",
99
"moonbit-community/proton_clipboard@0.1.14",
1010
"moonbit-community/proton_tray@0.1.14",
1111
"moonbit-community/proton_global_hotkey@0.1.14",

moon.work

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
members = [
2-
"../async",
32
"./cdp",
43
"./client",
54
"./contract",

proton/moon.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
"moonbit-community/proton_contract@0.1.14",
99
"moonbit-community/proton_updater@0.1.14",
1010
"moonbit-community/proton_rsa@0.1.14",
11-
"moonbitlang/async@0.20.3",
11+
"moonbitlang/async@0.20.4",
1212
"moonbitlang/x@0.4.48",
1313
"moonbitlang/lexer@0.3.5",
1414
}

0 commit comments

Comments
 (0)