Skip to content

Commit 7693ea9

Browse files
Merge pull request #896 from moosetechnology/846-remove-FamixTWithAnnotationInstanceAttributes
Fix #846 Remove TWithAnnotationInstanceAttributes
2 parents c03ed2f + 2b0f39c commit 7693ea9

11 files changed

+42
-84
lines changed

src/Famix-Java-Entities/FamixJavaAnnotationInstance.class.st

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### Children
66
| Relation | Origin | Opposite | Type | Comment |
77
|---|
8-
| `attributes` | `FamixTWithAnnotationInstanceAttributes` | `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | This corresponds to the actual values of the attributes in an AnnotationInstance|
8+
| `attributes` | `FamixTAnnotationInstance` | `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | This corresponds to the actual values of the attributes in an AnnotationInstance|
99
1010
### Other
1111
| Relation | Origin | Opposite | Type | Comment |
@@ -19,8 +19,8 @@
1919
Class {
2020
#name : #FamixJavaAnnotationInstance,
2121
#superclass : #FamixJavaSourcedEntity,
22-
#traits : 'FamixTAnnotationInstance + FamixTTypedAnnotationInstance + FamixTWithAnnotationInstanceAttributes',
23-
#classTraits : 'FamixTAnnotationInstance classTrait + FamixTTypedAnnotationInstance classTrait + FamixTWithAnnotationInstanceAttributes classTrait',
22+
#traits : 'FamixTAnnotationInstance + FamixTTypedAnnotationInstance',
23+
#classTraits : 'FamixTAnnotationInstance classTrait + FamixTTypedAnnotationInstance classTrait',
2424
#category : #'Famix-Java-Entities-Entities'
2525
}
2626

src/Famix-Java-Entities/FamixJavaAnnotationInstanceAttribute.class.st

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### Parents
66
| Relation | Origin | Opposite | Type | Comment |
77
|---|
8-
| `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | `attributes` | `FamixTWithAnnotationInstanceAttributes` | The instance of the annotation in which the attribute is used.|
8+
| `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | `attributes` | `FamixTAnnotationInstance` | The instance of the annotation in which the attribute is used.|
99
1010
### Other
1111
| Relation | Origin | Opposite | Type | Comment |

src/Famix-Java-Generator/FamixJavaGenerator.class.st

-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,6 @@ FamixJavaGenerator >> defineHierarchy [
183183

184184
annotationInstance --|> sourcedEntity.
185185
annotationInstance --|> #TAnnotationInstance.
186-
annotationInstance --|> #TWithAnnotationInstanceAttributes.
187186
annotationInstance --|> #TTypedAnnotationInstance.
188187

189188
annotationInstanceAttribute --|> sourcedEntity.

src/Famix-MetamodelGeneration/FamixGenerator.class.st

+1-11
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ Class {
5858
'tTypedAnnotationInstance',
5959
'tTypedAnnotationInstanceAttribute',
6060
'tWithAccesses',
61-
'tWithAnnotationInstanceAttributes',
6261
'tWithAnnotationInstances',
6362
'tWithAnnotationTypes',
6463
'tWithAttributes',
@@ -840,12 +839,6 @@ FamixGenerator >> commentForTWithAccesses [
840839
^ ''
841840
]
842841

843-
{ #category : #comments }
844-
FamixGenerator >> commentForTWithAnnotationInstanceAttributes [
845-
846-
^ ''
847-
]
848-
849842
{ #category : #comments }
850843
FamixGenerator >> commentForTWithAnnotationInstances [
851844

@@ -1295,7 +1288,7 @@ FamixGenerator >> defineRelations [
12951288
comment: 'The instance of the annotation in which the attribute is used.';
12961289
container)
12971290
*-
1298-
((tWithAnnotationInstanceAttributes property: #attributes)
1291+
((tAnnotationInstance property: #attributes)
12991292
comment: 'This corresponds to the actual values of the attributes in an AnnotationInstance').
13001293

13011294
((tAnnotationType property: #instances)
@@ -1825,9 +1818,6 @@ FamixGenerator >> defineTraits [
18251818
tWithAccesses := builder newTraitNamed: #TWithAccesses.
18261819
tWithAccesses comment: self commentForTWithAccesses.
18271820

1828-
tWithAnnotationInstanceAttributes := builder newTraitNamed: #TWithAnnotationInstanceAttributes.
1829-
tWithAnnotationInstanceAttributes comment: self commentForTWithAnnotationInstanceAttributes.
1830-
18311821
tWithAnnotationInstances := builder newTraitNamed: #TWithAnnotationInstances.
18321822
tWithAnnotationInstances comment: self commentForTWithAnnotationInstances.
18331823

src/Famix-PharoSmalltalk-Entities/FamixStAnnotationInstance.class.st

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### Children
66
| Relation | Origin | Opposite | Type | Comment |
77
|---|
8-
| `attributes` | `FamixTWithAnnotationInstanceAttributes` | `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | This corresponds to the actual values of the attributes in an AnnotationInstance|
8+
| `attributes` | `FamixTAnnotationInstance` | `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | This corresponds to the actual values of the attributes in an AnnotationInstance|
99
1010
### Other
1111
| Relation | Origin | Opposite | Type | Comment |
@@ -19,8 +19,8 @@
1919
Class {
2020
#name : #FamixStAnnotationInstance,
2121
#superclass : #FamixStSourcedEntity,
22-
#traits : 'FamixTAnnotationInstance + FamixTTypedAnnotationInstance + FamixTWithAnnotationInstanceAttributes',
23-
#classTraits : 'FamixTAnnotationInstance classTrait + FamixTTypedAnnotationInstance classTrait + FamixTWithAnnotationInstanceAttributes classTrait',
22+
#traits : 'FamixTAnnotationInstance + FamixTTypedAnnotationInstance',
23+
#classTraits : 'FamixTAnnotationInstance classTrait + FamixTTypedAnnotationInstance classTrait',
2424
#category : #'Famix-PharoSmalltalk-Entities-Entities'
2525
}
2626

src/Famix-PharoSmalltalk-Entities/FamixStAnnotationInstanceAttribute.class.st

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### Parents
66
| Relation | Origin | Opposite | Type | Comment |
77
|---|
8-
| `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | `attributes` | `FamixTWithAnnotationInstanceAttributes` | The instance of the annotation in which the attribute is used.|
8+
| `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | `attributes` | `FamixTAnnotationInstance` | The instance of the annotation in which the attribute is used.|
99
1010
### Other
1111
| Relation | Origin | Opposite | Type | Comment |

src/Famix-PharoSmalltalk-Generator/FamixPharoSmalltalkGenerator.class.st

-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ FamixPharoSmalltalkGenerator >> defineHierarchy [
7272

7373
annotationInstance --|> sourcedEntity.
7474
annotationInstance --|> #TAnnotationInstance.
75-
annotationInstance --|> #TWithAnnotationInstanceAttributes.
7675
annotationInstance --|> #TTypedAnnotationInstance.
7776

7877
annotationInstanceAttribute --|> sourcedEntity.

src/Famix-Traits/FamixTAnnotationInstance.trait.st

+30-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ Instance Variables:
1414
## Relations
1515
======================
1616
17+
### Children
18+
| Relation | Origin | Opposite | Type | Comment |
19+
|---|
20+
| `attributes` | `FamixTAnnotationInstance` | `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | This corresponds to the actual values of the attributes in an AnnotationInstance|
21+
1722
### Other
1823
| Relation | Origin | Opposite | Type | Comment |
1924
|---|
@@ -25,7 +30,8 @@ Instance Variables:
2530
Trait {
2631
#name : #FamixTAnnotationInstance,
2732
#instVars : [
28-
'#annotatedEntity => FMOne type: #FamixTWithAnnotationInstances opposite: #annotationInstances'
33+
'#annotatedEntity => FMOne type: #FamixTWithAnnotationInstances opposite: #annotationInstances',
34+
'#attributes => FMMany type: #FamixTAnnotationInstanceAttribute opposite: #parentAnnotationInstance'
2935
],
3036
#traits : 'TEntityMetaLevelDependency',
3137
#classTraits : 'TEntityMetaLevelDependency classTrait',
@@ -48,6 +54,12 @@ FamixTAnnotationInstance classSide >> annotationFamixAnnotationInstanceGroup [
4854
^ FamixAnnotationInstanceGroup
4955
]
5056

57+
{ #category : #adding }
58+
FamixTAnnotationInstance >> addAttribute: anObject [
59+
<generated>
60+
^ self attributes add: anObject
61+
]
62+
5163
{ #category : #accessing }
5264
FamixTAnnotationInstance >> annotatedEntity [
5365
"Relation named: #annotatedEntity type: #FamixTWithAnnotationInstances opposite: #annotationInstances"
@@ -64,6 +76,23 @@ FamixTAnnotationInstance >> annotatedEntity: anObject [
6476
annotatedEntity := anObject
6577
]
6678

79+
{ #category : #accessing }
80+
FamixTAnnotationInstance >> attributes [
81+
"Relation named: #attributes type: #FamixTAnnotationInstanceAttribute opposite: #parentAnnotationInstance"
82+
83+
<generated>
84+
<FMComment: 'This corresponds to the actual values of the attributes in an AnnotationInstance'>
85+
<derived>
86+
^ attributes
87+
]
88+
89+
{ #category : #accessing }
90+
FamixTAnnotationInstance >> attributes: anObject [
91+
92+
<generated>
93+
attributes value: anObject
94+
]
95+
6796
{ #category : #printing }
6897
FamixTAnnotationInstance >> displayStringOn: aStream [
6998

src/Famix-Traits/FamixTAnnotationInstanceAttribute.trait.st

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Instance Variables:
1515
### Parents
1616
| Relation | Origin | Opposite | Type | Comment |
1717
|---|
18-
| `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | `attributes` | `FamixTWithAnnotationInstanceAttributes` | The instance of the annotation in which the attribute is used.|
18+
| `parentAnnotationInstance` | `FamixTAnnotationInstanceAttribute` | `attributes` | `FamixTAnnotationInstance` | The instance of the annotation in which the attribute is used.|
1919
2020
2121
## Properties
@@ -29,7 +29,7 @@ Instance Variables:
2929
Trait {
3030
#name : #FamixTAnnotationInstanceAttribute,
3131
#instVars : [
32-
'#parentAnnotationInstance => FMOne type: #FamixTWithAnnotationInstanceAttributes opposite: #attributes',
32+
'#parentAnnotationInstance => FMOne type: #FamixTAnnotationInstance opposite: #attributes',
3333
'#value => FMProperty'
3434
],
3535
#traits : 'TEntityMetaLevelDependency',
@@ -48,7 +48,7 @@ FamixTAnnotationInstanceAttribute classSide >> annotation [
4848

4949
{ #category : #accessing }
5050
FamixTAnnotationInstanceAttribute >> parentAnnotationInstance [
51-
"Relation named: #parentAnnotationInstance type: #FamixTWithAnnotationInstanceAttributes opposite: #attributes"
51+
"Relation named: #parentAnnotationInstance type: #FamixTAnnotationInstance opposite: #attributes"
5252

5353
<generated>
5454
<FMComment: 'The instance of the annotation in which the attribute is used.'>

src/Famix-Traits/FamixTWithAnnotationInstanceAttributes.trait.st

-50
This file was deleted.

src/Famix-Visitor/FamixTWithAnnotationInstanceAttributes.extension.st

-9
This file was deleted.

0 commit comments

Comments
 (0)