Game Scanner won't add some installed EA App Games

[nicosuchtet]

I have installed some games through the EA App, but the game scanner only adds certain ones. After closer inspection, I noticed that older titles, such as Need for Speed Shift, are affected. When checking the installation path, I found the (possible) issue: some older games are installed under C:\Program Files (x86)\EA Games instead of Program Files (without x86).

[moraroy]

@nicosuchtet nice catch, will try to fix

[nicosuchtet]

Since I have some older Need for Speed games in the EA App, I did some testing. In the EA App prefix, I created a symbolic link in the Program Files folder (without x86) that points to the Program Files (x86) folder, so that the App Scanner can create them as shortcuts under Steam. Some of them are detected by the scanner (e.g., Shift 2 Unleashed), but others are not (Shift 1).

If I understood the EA App Game Scanner correctly, it looks in the game directory inside the installerdata.xml file (under __Installer) for the OfferID. However, since for example NfS Shift 1 does not have an OfferID in the XML, the scanner does not detect the game. It might be more useful, for extracting the OfferID, if the scanner checked the prefix’s registry instead. The EA App stores them under the following path:
HKEY_LOCAL_MACHINE\Software\Wow6432Node\Origin Games\

Very old EA games also use string-based OfferIDs (i.e., no numbers).
I hope my test/workaround is helpful for fixing the bug.

[moraroy]

@nicosuchtet can you upload the .xml file so i can read it? it may have other info... maybe there are other files that have the offerID... im trying to avoid reading the sysregistry if necessary, if not its cool just let me know

[nicosuchtet]

Here are the .xml files.
I add the .xml from different games, so you can compare them.

shift2_installerdata.xml
shift_installerdata.xml
undecover_installerdata.xml

[moraroy]

@nicosuchtet cool thank you, that was helpful, i see what you mean now by no ContentID, i went ahead and attemtped a fix, let me know if its picking up all of your EA Games. please Run the NonSteamLaunchers.desktop so the scanner can update and run.

[nicosuchtet]

I ran the .desktop file and updated the scanner, but it still doesn't add the affected games.

[moraroy]

@nicosuchtet what does the log say this time?

[nicosuchtet]

Here is a fresh log.

NonSteamLaunchers-install.log