Skip to content

Commit c670d9d

Browse files
Fixed reported issue #42 regarding connition=local (#42)
* Fixed reported issue #42 regarding connition=local * Update main.yml nvm version update
1 parent 4bd8f8c commit c670d9d

3 files changed

Lines changed: 14 additions & 3 deletions

File tree

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,7 @@ Another example
307307
308308
pre_tasks:
309309
310+
# test-user needs to be a real user on the system before we can install nvm in their profile
310311
- name: add new user
311312
user:
312313
name: "test-user"
@@ -486,6 +487,10 @@ None.
486487

487488
## Change Log
488489
---
490+
**1.5.2**
491+
* [@neutralalice](https://github.com/morgangraphics/ansible-role-nvm/issues/41) reported issue with connection=local issues
492+
* NVM Version update
493+
* Comment in example to make things more clear about users needed to exist on the system before installation
489494

490495
**1.5.1**
491496
* [@otsuka](https://github.com/morgangraphics/ansible-role-nvm/issues/39) reported issue with version numbering mismatch

defaults/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
#SEMVER
3-
role_version: "1.5.1"
3+
role_version: "1.5.2"
44

55
role_repo: "https://github.com/morgangraphics/ansible-role-nvm"
66

@@ -60,13 +60,13 @@ nvm_install: "wget"
6060
# BASH: .bashrc
6161
# ZSH: .zshrc
6262
#
63-
nvm_profile: ".bashrc"
63+
nvm_profile: "~/.bashrc"
6464

6565
# NVM source location - i.e. you host your own fork
6666
nvm_source: ""
6767

6868
# Version of NVM to install
69-
nvm_version: "0.39.3"
69+
nvm_version: "0.39.5"
7070

7171
# Uninstall NVM
7272
uninstall: false

tasks/nvm.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@
6262

6363
- name: Create profile file if it does not exist
6464
file:
65+
group: "{{ ansible_become_user | default(ansible_user) }}"
66+
owner: "{{ ansible_become_user | default(ansible_user) }}"
6567
mode: 0777
6668
path: "{{ nvm_profile }}"
6769
state: touch
@@ -90,6 +92,8 @@
9092

9193
- name: Create nvm_dir if it does not exist
9294
file:
95+
group: "{{ ansible_become_user | default(ansible_user) }}"
96+
owner: "{{ ansible_become_user | default(ansible_user) }}"
9397
mode: 0775
9498
path: "{{ nvm_dir }}"
9599
state: directory
@@ -109,6 +113,8 @@
109113

110114
- name: Update profile permissions to lock it down after writing
111115
file:
116+
group: "{{ ansible_become_user | default(ansible_user) }}"
117+
owner: "{{ ansible_become_user | default(ansible_user) }}"
112118
mode: 0644
113119
path: "{{ nvm_profile }}"
114120
become: true

0 commit comments

Comments
 (0)