refactor: simplify title types (#8)

* refactor: simplify title types

* Add large-ads-kiss.md

Author: morinokami

.changeset/large-ads-kiss.md

@@ -0,0 +1,5 @@
+---
+"tanstack-meta": patch
+---
+
+refactor: simplify title types

packages/meta/src/normalize/opengraph.ts

@@ -1,4 +1,4 @@
-import type { InputMetadata, SimplifyTitleInUnion } from "../types/io";
+import type { InputMetadata } from "../types/io";
 import type {
 	ResolvedMetadata,
 	ResolvedMetadataWithURLs,
@@ -125,9 +125,7 @@ function getFieldsByOgType(ogType: OpenGraphType | undefined) {
 export function normalizeOpenGraph(openGraph: InputMetadata["openGraph"]) {
 	if (!openGraph) return null;
 
-	type OpenGraphResolved = NonNullable<
-		SimplifyTitleInUnion<ResolvedMetadata["openGraph"]>
-	>;
+	type OpenGraphResolved = NonNullable<ResolvedMetadata["openGraph"]>;
 	type OpenGraphArrayKeys =
 		(typeof OgTypeFields)[keyof typeof OgTypeFields][number];
 
@@ -189,7 +187,7 @@ export function normalizeTwitter(twitter: InputMetadata["twitter"]) {
 	const resolved = {
 		...twitter,
 		title: twitter.title,
-	} as NonNullable<SimplifyTitleInUnion<ResolvedMetadata["twitter"]>>;
+	} as NonNullable<ResolvedMetadata["twitter"]>;
 	for (const infoKey of TwitterBasicInfoKeys) {
 		resolved[infoKey] = twitter[infoKey] || null;
 	}

packages/meta/src/types/io.ts

@@ -6,11 +6,6 @@ import type {
 	ResolvedMetadataWithURLs,
 } from "./metadata-interface";
 
-// Simplify the type of the title property in the opengraph type
-export type SimplifyTitleInUnion<T> = T extends { title?: unknown }
-	? Omit<T, "title"> & { title?: string }
-	: T;
-
 export type InputMetadata = {
 	/**
 	 * The character set of the document.
@@ -358,7 +353,7 @@ export type InputMetadata = {
 	 *
 	 * @see https://ogp.me/
 	 */
-	openGraph?: SimplifyTitleInUnion<NextMetadata["openGraph"]>;
+	openGraph?: NextMetadata["openGraph"];
 	/**
 	 * The Twitter metadata for the document.
 	 *
@@ -381,7 +376,7 @@ export type InputMetadata = {
 	 * // <meta name="twitter:image" content="https://example.com/og.png" />
 	 * ```
 	 */
-	twitter?: SimplifyTitleInUnion<NextMetadata["twitter"]>;
+	twitter?: NextMetadata["twitter"];
 	/**
 	 * The Facebook AppLinks metadata for the document.
 	 *
@@ -453,8 +448,8 @@ export type NormalizedMetadata = {
 	formatDetection: ResolvedMetadata["formatDetection"];
 	verification: ResolvedMetadata["verification"];
 	appleWebApp: ResolvedMetadata["appleWebApp"];
-	openGraph: SimplifyTitleInUnion<ResolvedMetadata["openGraph"]>;
-	twitter: SimplifyTitleInUnion<ResolvedMetadata["twitter"]>;
+	openGraph: ResolvedMetadata["openGraph"];
+	twitter: ResolvedMetadata["twitter"];
 	appLinks: ResolvedMetadataWithURLs["appLinks"];
 	icons: ResolvedMetadata["icons"];
 };

packages/meta/src/types/opengraph-types.ts

@@ -1,6 +1,6 @@
 // https://github.com/vercel/next.js/blob/f9f625b90e6d4a562758c6a43234e168dcc23aa1/packages/next/src/lib/metadata/types/opengraph-types.ts
 
-import type { AbsoluteTemplateString, TemplateString } from "./metadata-types";
+import type { AbsoluteTemplateString } from "./metadata-types";
 
 export type OpenGraphType =
 	| "article"
@@ -36,7 +36,7 @@ type Locale = string;
 
 type OpenGraphMetadata = {
 	determiner?: "a" | "an" | "the" | "auto" | "" | undefined;
-	title?: string | TemplateString | undefined;
+	title?: string | undefined;
 	description?: string | undefined;
 	emails?: string | Array<string> | undefined;
 	phoneNumbers?: string | Array<string> | undefined;
@@ -195,7 +195,7 @@ export type ResolvedOpenGraph =
 
 type ResolvedOpenGraphMetadata = {
 	determiner?: "a" | "an" | "the" | "auto" | "" | undefined;
-	title: AbsoluteTemplateString;
+	title?: string | undefined;
 	description?: string | undefined;
 	emails?: Array<string> | undefined;
 	phoneNumbers?: Array<string> | undefined;

packages/meta/src/types/twitter-types.ts

@@ -2,7 +2,7 @@
 
 // Reference: https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/markup
 
-import type { AbsoluteTemplateString, TemplateString } from "./metadata-types";
+import type { AbsoluteTemplateString } from "./metadata-types";
 
 export type Twitter =
 	| TwitterSummary
@@ -18,7 +18,7 @@ type TwitterMetadata = {
 	creator?: string | undefined; // username for the account associated to the creator of the content on the site
 	creatorId?: string | undefined; // id for the account associated to the creator of the content on the site
 	description?: string | undefined;
-	title?: string | TemplateString | undefined;
+	title?: string | undefined;
 	images?: TwitterImage | Array<TwitterImage> | undefined;
 };
 type TwitterSummary = TwitterMetadata & {
@@ -81,7 +81,7 @@ type ResolvedTwitterSummary = {
 	creator: string | null;
 	creatorId: string | null;
 	description: string | null;
-	title: AbsoluteTemplateString;
+	title?: string | undefined;
 	images?: Array<ResolvedTwitterImage> | undefined;
 };
 type ResolvedTwitterPlayer = ResolvedTwitterSummary & {