refactor(test): keep coverage at behavioral boundaries (#474)

* refactor(test): keep coverage at behavioral boundaries

* fix(ci): restore package workflow temp-root classification

Author: morluto

docs/testing.md

@@ -25,10 +25,10 @@ registries but do not cross production filesystem, process, socket, or browser b
 Boundary tests cross one production boundary. Only acceptance tests assemble
 the complete runtime or invoke the compiled product surface.
 
-Focused immutable builders shared by a domain test family live beside their
-production owner as `src/domain/*.fixture.ts`. They are typechecked with the
-suite and excluded from package builds; broader runtime and provider fixtures
-remain under `tests/fixtures/**`.
+Focused immutable builders and recording ports shared by one test family live
+beside their production owner as `src/**/*.fixture.ts`. They are typechecked
+with the suite and excluded from package builds; broader runtime and provider
+fixtures remain under `tests/fixtures/**`.
 
 `tests/process-global/**` is reserved for cases with a demonstrated dependency
 on process-global state. Those tests run without file parallelism. Reusable,
@@ -70,8 +70,10 @@ Local full-suite Vitest runs are intentionally capped at one worker and one
 project at a time. Boundary fixtures own real subprocesses, and this local cap
 keeps aggregate memory predictable; CI retains the existing two-worker budget.
 The pure domain/contracts and recording-port service projects share one worker
-module context because their tests own no mutable runtime resources; adapter,
-composition, and boundary projects retain per-file isolation.
+module context because their tests own no mutable runtime resources. MCP
+boundary files also share the immutable server module graph while creating and
+closing independent in-memory sessions. Adapter, composition, acceptance,
+process-global, and other boundary projects retain per-file isolation.
 `npm test`, `npm run docs:check`, and `npm run docs:generate` share
 repository-local locks and fail fast when the same class of command is already
 running. The `npm test` build is inside that lock. `check:pr` runs its test task

knip.json

@@ -1,6 +1,6 @@
 {
   "$schema": "./node_modules/knip/schema.json",
-  "entry": ["src/main.ts", "src/cli.ts"],
+  "entry": ["src/main.ts", "src/cli.ts", "src/contracts/errorSchemas.ts"],
   "project": ["src/**/*.ts", "tests/**/*.ts", "scripts/**/*.mjs"],
   "ignoreDependencies": ["electron"],
   "ignoreBinaries": ["ps"],

…essions/analysisProviderRegistry.test.ts …ication/AnalysisProviderRegistry.test.tstests/composition/analysis-sessions/analysisProviderRegistry.test.ts renamed to src/application/AnalysisProviderRegistry.test.ts tests/composition/analysis-sessions/analysisProviderRegistry.test.ts renamed to src/application/AnalysisProviderRegistry.test.ts

@@ -3,7 +3,7 @@ import { describe, expect, it } from "vitest";
 import {
   AnalysisProviderRegistry,
   type AnalysisProviderBinding,
-} from "../../../src/application/AnalysisProviderRegistry.js";
+} from "./AnalysisProviderRegistry.js";
 import {
   createAnalysisExecution,
   type AnalysisClient,
@@ -12,15 +12,15 @@ import {
   type ProviderAvailability,
   type ProviderIdentity,
   type ProviderTargetSupport,
-} from "../../../src/application/AnalysisProvider.js";
-import { createAnalysisProfile } from "../../../src/domain/analysisProfile.js";
-import type { BinaryTarget } from "../../../src/domain/binaryTarget.js";
+} from "./AnalysisProvider.js";
+import { createAnalysisProfile } from "../domain/analysisProfile.js";
+import type { BinaryTarget } from "../domain/binaryTarget.js";
 import {
   ProviderAdapterError,
   ProviderSelectionError,
   projectAnalysisError,
-} from "../../../src/domain/errors.js";
-import { err, ok } from "../../../src/domain/result.js";
+} from "../domain/errors.js";
+import { err, ok } from "../domain/result.js";
 
 const DATABASE_TARGET: BinaryTarget = {
   path: "/tmp/fixture.hop",

src/application/Doctor.fixture.ts

@@ -0,0 +1,32 @@
+import { CATALOG_IDENTITY } from "../catalogIdentity.js";
+import { PRODUCT_IDENTITY } from "../identity.js";
+import type { DoctorHost } from "./Doctor.js";
+
+/** Healthy recording host for focused doctor and projection tests. */
+export const createDoctorHostFixture = (
+  overrides: Partial<DoctorHost> = {},
+): DoctorHost => ({
+  platform: "darwin",
+  architecture: "x64",
+  nodeVersion: "24.18.0",
+  macosVersion: () => Promise.resolve("14.0"),
+  linuxDistribution: () => Promise.resolve(undefined),
+  validTarget: (path) => Promise.resolve(path.includes("Hopper")),
+  executable: (path) => Promise.resolve(path.includes("Hopper")),
+  supportedLinuxHopper: () => Promise.resolve(true),
+  linuxDemoRuntimeCheck: () =>
+    Promise.resolve({
+      name: "hopper-demo-runtime",
+      ok: true,
+      classification: "healthy",
+    }),
+  brewHopperPath: () => Promise.resolve(undefined),
+  manualHopperPaths: () => Promise.resolve([]),
+  installedSkillIdentity: () =>
+    Promise.resolve({
+      version: PRODUCT_IDENTITY.skillVersion,
+      toolCount: CATALOG_IDENTITY.counts.mcp_tools,
+      catalogDigest: CATALOG_IDENTITY.digests.combined_sha256,
+    }),
+  ...overrides,
+});

…ary/cli/doctorRuntimeExecutables.test.ts …cation/Doctor.runtimeExecutables.test.tstests/boundary/cli/doctorRuntimeExecutables.test.ts renamed to src/application/Doctor.runtimeExecutables.test.ts tests/boundary/cli/doctorRuntimeExecutables.test.ts renamed to src/application/Doctor.runtimeExecutables.test.ts

@@ -1,34 +1,7 @@
 import { describe, expect, it } from "vitest";
 
-import { runDoctor, type DoctorHost } from "../../../src/application/Doctor.js";
-import { CATALOG_IDENTITY } from "../../../src/catalogIdentity.js";
-import { PRODUCT_IDENTITY } from "../../../src/identity.js";
-
-const host = (overrides: Partial<DoctorHost> = {}): DoctorHost => ({
-  platform: "darwin",
-  architecture: "x64",
-  nodeVersion: "24.18.0",
-  macosVersion: () => Promise.resolve("12.0"),
-  linuxDistribution: () => Promise.resolve(undefined),
-  validTarget: (path) => Promise.resolve(path.includes("Hopper")),
-  executable: (path) => Promise.resolve(path.includes("Hopper")),
-  supportedLinuxHopper: () => Promise.resolve(true),
-  linuxDemoRuntimeCheck: () =>
-    Promise.resolve({
-      name: "hopper-demo-runtime",
-      ok: true,
-      classification: "healthy",
-    }),
-  brewHopperPath: () => Promise.resolve(undefined),
-  manualHopperPaths: () => Promise.resolve([]),
-  installedSkillIdentity: () =>
-    Promise.resolve({
-      version: PRODUCT_IDENTITY.skillVersion,
-      toolCount: CATALOG_IDENTITY.counts.mcp_tools,
-      catalogDigest: CATALOG_IDENTITY.digests.combined_sha256,
-    }),
-  ...overrides,
-});
+import { createDoctorHostFixture as host } from "./Doctor.fixture.js";
+import { runDoctor } from "./Doctor.js";
 
 describe("doctor runtime executable diagnostics", () => {
   it("reports a broken shadowed Node candidate without hiding the healthy launcher", async () => {

tests/boundary/cli/doctor.test.ts src/application/Doctor.test.tstests/boundary/cli/doctor.test.ts renamed to src/application/Doctor.test.ts

@@ -1,34 +1,7 @@
 import { describe, expect, it } from "vitest";
-import type { ClientRegistrationStatus } from "../../../src/application/ClientRegistrationStatus.js";
-import { runDoctor, type DoctorHost } from "../../../src/application/Doctor.js";
-import { CATALOG_IDENTITY } from "../../../src/catalogIdentity.js";
-import { PRODUCT_IDENTITY } from "../../../src/identity.js";
-
-const host = (overrides: Partial<DoctorHost> = {}): DoctorHost => ({
-  platform: "darwin",
-  architecture: "x64",
-  nodeVersion: "24.18.0",
-  macosVersion: () => Promise.resolve("12.0"),
-  linuxDistribution: () => Promise.resolve(undefined),
-  validTarget: (path) => Promise.resolve(path.includes("Hopper")),
-  executable: (path) => Promise.resolve(path.includes("Hopper")),
-  supportedLinuxHopper: () => Promise.resolve(true),
-  linuxDemoRuntimeCheck: () =>
-    Promise.resolve({
-      name: "hopper-demo-runtime",
-      ok: true,
-      classification: "healthy",
-    }),
-  brewHopperPath: () => Promise.resolve(undefined),
-  manualHopperPaths: () => Promise.resolve([]),
-  installedSkillIdentity: () =>
-    Promise.resolve({
-      version: PRODUCT_IDENTITY.skillVersion,
-      toolCount: CATALOG_IDENTITY.counts.mcp_tools,
-      catalogDigest: CATALOG_IDENTITY.digests.combined_sha256,
-    }),
-  ...overrides,
-});
+import type { ClientRegistrationStatus } from "./ClientRegistrationStatus.js";
+import { createDoctorHostFixture as host } from "./Doctor.fixture.js";
+import { runDoctor } from "./Doctor.js";
 
 describe("doctor", () => {
   it("returns exact recovery for every failed diagnostic", async () => {

…ary/providers/hopper/linuxHopper.test.ts src/application/LinuxHopper.test.tstests/boundary/providers/hopper/linuxHopper.test.ts renamed to src/application/LinuxHopper.test.ts tests/boundary/providers/hopper/linuxHopper.test.ts renamed to src/application/LinuxHopper.test.ts

@@ -12,7 +12,7 @@ import {
   type LinuxHopperInstallHost,
   type LinuxHopperLauncherStatus,
   type LinuxPackageFamily,
-} from "../../../../src/application/LinuxHopper.js";
+} from "./LinuxHopper.js";
 
 class RecordingLinuxHost implements LinuxHopperInstallHost {
   distributionValue: LinuxDistribution | undefined = {

…ndary/providers/hopper/macHopper.test.ts src/application/MacHopper.test.tstests/boundary/providers/hopper/macHopper.test.ts renamed to src/application/MacHopper.test.ts tests/boundary/providers/hopper/macHopper.test.ts renamed to src/application/MacHopper.test.ts

@@ -6,7 +6,7 @@ import {
   installMacHopper,
   macHopperInstallDisclosure,
   type MacHopperInstallHost,
-} from "../../../../src/application/MacHopper.js";
+} from "./MacHopper.js";
 
 class FakeMacHopperHost implements MacHopperInstallHost {
   readonly archive = new TextEncoder().encode("hopper-dmg");

…rs/managed/managedReconstruction.test.ts …ion/ManagedReconstructionService.test.tstests/boundary/providers/managed/managedReconstruction.test.ts renamed to src/application/ManagedReconstructionService.test.ts tests/boundary/providers/managed/managedReconstruction.test.ts renamed to src/application/ManagedReconstructionService.test.ts

@@ -2,14 +2,14 @@ import { createHash } from "node:crypto";
 
 import { describe, expect, it } from "vitest";
 
-import { importManagedReconstructionEvidence } from "../../../../src/application/ManagedReconstructionService.js";
-import { MANAGED_RECONSTRUCTION_IMPORT_EXAMPLE } from "../../../../src/contracts/managedWorkflowExamples.js";
+import { MANAGED_RECONSTRUCTION_IMPORT_EXAMPLE } from "../contracts/managedWorkflowExamples.js";
 import {
   importManagedReconstruction,
   managedReconstructionImportInputSchema,
-} from "../../../../src/domain/managedReconstruction.js";
-import { managedMemberInspectionSchema } from "../../../../src/domain/managedArtifact.js";
-import { createEvidence } from "../../../../src/domain/evidence.js";
+} from "../domain/managedReconstruction.js";
+import { managedMemberInspectionSchema } from "../domain/managedArtifact.js";
+import { createEvidence } from "../domain/evidence.js";
+import { importManagedReconstructionEvidence } from "./ManagedReconstructionService.js";
 
 const exampleInput = () =>
   managedReconstructionImportInputSchema.parse(

…iders/native/nativeApiInspection.test.ts …/application/NativeApiInspection.test.tstests/boundary/providers/native/nativeApiInspection.test.ts renamed to src/application/NativeApiInspection.test.ts tests/boundary/providers/native/nativeApiInspection.test.ts renamed to src/application/NativeApiInspection.test.ts

@@ -1,9 +1,9 @@
 import { describe, expect, it } from "vitest";
 
-import { projectNativeApiInspection } from "../../../../src/application/NativeApiInspection.js";
-import { functionDossierSchema } from "../../../../src/domain/hopperValues.js";
-import { nativeApiBoundarySchema } from "../../../../src/domain/nativeApiBoundary.js";
-import { ghidraFunctionDossier } from "../../../fixtures/ghidraFunction.js";
+import { functionDossierSchema } from "../domain/hopperValues.js";
+import { ghidraFunctionDossier } from "../domain/hopperValues.fixture.js";
+import { nativeApiBoundarySchema } from "../domain/nativeApiBoundary.js";
+import { projectNativeApiInspection } from "./NativeApiInspection.js";
 
 describe("native API inspection", () => {
   it("projects structured boundary evidence through inspectable substeps", () => {