Merge branch '4.3.x' into 5.0.x

Author: morozov

UPGRADE.md

@@ -187,6 +187,17 @@ all drivers and middleware.
 
 # Upgrade to 4.3
 
+## Deprecated not passing `$options` to `AbstractPlatform::_getCreateTableSQL()`
+
+Not passing the `$options` argument or any of its following keys to the `AbstractPlatform::_getCreateTableSQL()` method
+has been deprecated: `primary`, `indexes`, `uniqueConstraints`, `foreignKeys`.
+
+## Deprecated check-related features
+
+1. The `AbstractPlatform::getCheckDeclarationSQL()` method has been marked as internal.
+2. Passing string elements as part of the `$definition` argument to `AbstractPlatform::getCheckDeclarationSQL()` is
+   deprecated. Pass column definitions represented as array instead.
+
 ## Deprecated `Index` usage scenarios
 
 The following `Index` usage scenarios have been deprecated:

src/Platforms/AbstractMySQLPlatform.php

@@ -229,6 +229,8 @@ public function getColumnTypeSQLSnippet(string $tableAlias, string $databaseName
      */
     protected function _getCreateTableSQL(string $name, array $columns, array $options = []): array
     {
+        $this->validateCreateTableOptions($options, __METHOD__);
+
         $queryFields = $this->getColumnDeclarationListSQL($columns);
 
         if (! empty($options['uniqueConstraints'])) {
@@ -668,12 +670,13 @@ private function getUnsignedDeclaration(array $columnDef): string
      */
     protected function _getCommonIntegerTypeDeclarationSQL(array $column): string
     {
-        $autoinc = '';
+        $sql = $this->getUnsignedDeclaration($column);
+
         if (! empty($column['autoincrement'])) {
-            $autoinc = ' AUTO_INCREMENT';
+            $sql .= ' AUTO_INCREMENT';
         }
 
-        return $this->getUnsignedDeclaration($column) . $autoinc;
+        return $sql;
     }
 
     protected function getColumnCharsetDeclarationSQL(string $charset): string