Improved subf2m privider to fall back to IMDB id search when localized movie title finds nothing

Author: luuvasara

custom_libs/subliminal_patch/providers/subf2m.py

@@ -376,6 +376,16 @@ def list_subtitles(self, video, languages):
             paths = self._search_tv_show_season(video.series, video.season, video.year)
         else:
             paths = self._search_movie(video.title, video.year)
+            if not paths and video.imdb_id:
+                # video.title may be a localized title that subf2m doesn't index
+                # (e.g. Radarr providing a non-English title). subf2m's
+                # searchbytitle also accepts an IMDB id, so fall back to it.
+                logger.debug(
+                    "No results for title %r; retrying search with IMDB id %s",
+                    video.title,
+                    video.imdb_id,
+                )
+                paths = self._search_movie(video.imdb_id, video.year)
 
         if not paths:
             logger.debug("No results")

tests/subliminal_patch/test_subf2m.py

@@ -1,5 +1,6 @@
 import pytest
 from subliminal_patch.core import Episode
+from subliminal_patch.core import Movie
 from subliminal_patch.providers import subf2m
 from subliminal_patch.providers.subf2m import ConfigurationError
 from subliminal_patch.providers.subf2m import Subf2mProvider
@@ -32,6 +33,20 @@ def test_search_movie(provider, title, year, expected_url):
     assert expected_url in result
 
 
+def test_list_subtitles_movie_falls_back_to_imdb_id(provider):
+    # Radarr may provide a localized movie title that subf2m doesn't index
+    # (here the Danish title for "The Goonies"). The provider should fall back
+    # to searching by IMDB id rather than finding nothing. Regression for #2896.
+    movie = Movie(
+        "Goonierne.1985.1080p.BluRay.x264-GROUP",
+        "Goonierne",
+        year=1985,
+        imdb_id="tt0089218",
+    )
+    subtitles = provider.list_subtitles(movie, {Language.fromalpha2("en")})
+    assert subtitles
+
+
 def test_init_empty_user_agent_raises_configurationerror():
     with pytest.raises(ConfigurationError):
         with Subf2mProvider(user_agent=" ") as provider: