Fix window size according to system font size (close #11)

Author: morpheusthewhite

bin/font_size.py

@@ -0,0 +1,18 @@
+from tkinter import font
+
+FONT_DEFAULT_SIZE = 9
+FONT_DEFAULT_SIZE_PIXEL = -12
+
+def get_font_scale_factor(font_name):
+    """
+    Calculate the ratio between the system font and the default font, on which default sizes are based
+    :return the ratio between system font (currently used) and the default font 
+    """
+    font_size_system = font.nametofont(font_name).cget("size")
+    
+    if font_size_system > 0:
+        # pt size
+        return font_size_system / FONT_DEFAULT_SIZE
+    else:
+        return font_size_system / FONT_DEFAULT_SIZE_PIXEL
+

bin/gui.py

@@ -10,19 +10,19 @@
 from bin.vpn_util.vpn import *
 from bin.gui_components.settings_frame import SettingsFrame
 from bin.gui_components.advanced_settings_window import DEFAULT_SCALE_FACTOR, DEFAULT_NM_USE
+from bin.font_size import get_font_scale_factor
 import threading
 
 logger = get_logger(__name__)
 
 DEFAUL_WIDTH = 370
 DEFAUL_HEIGHT = 340
 
-
 class gui(Tk):
     def __init__(self):
         super().__init__()
         self.wm_title("NordPY")
-
+        
         # sets the icon
         self.__imgicon__ = PhotoImage(file=os.path.join(CURRENT_PATH+"media", "nordvpn.png"))
         self.tk.call('wm', 'iconphoto', self._w, self.__imgicon__)
@@ -34,15 +34,15 @@ def __init__(self):
         else:
             (self.scale_factor, self.nm_use) = (DEFAULT_SCALE_FACTOR, DEFAULT_NM_USE)
 
-        self.center_window(DEFAUL_WIDTH, DEFAUL_HEIGHT, self.scale_factor)
-
         self.settings_frame = SettingsFrame(self, self.scale_factor)
         self.manual_frame = ManualSelectionFrame(self, self.background_color, self.scale_factor)
         self.optionsFrame = OptionFrame(self)
         self.__init_protocol__()
         self.__initStatus__()
         self.__initButtons__()
 
+        self.center_window(DEFAUL_WIDTH, DEFAUL_HEIGHT, self.scale_factor, self.optionsFrame.cget("font"))
+
         running_vpn = get_running_vpn()
         if running_vpn is not None:
             self.setStatusAlreadyConnected(running_vpn)
@@ -251,13 +251,16 @@ def reset_settings(self):
     def update_advanced_settings(self, nm_use):
         self.nm_use = nm_use
 
-    def center_window(self, width=300, height=200, scale=DEFAULT_SCALE_FACTOR):
+    def center_window(self, width=300, height=200, scale=DEFAULT_SCALE_FACTOR, font_name="TkDefaultFont"):
         # gets screen width and height
         screen_width = self.winfo_screenwidth()
         screen_height = self.winfo_screenheight()
 
-        scaled_width = width * scale
-        scaled_height = height * scale
+        font_factor = get_font_scale_factor(font_name)
+        logger.info("Font factor: " + str(font_factor))
+
+        scaled_width = width * scale * font_factor
+        scaled_height = height * scale * font_factor
 
         # calculates position x and y coordinates
         x = (screen_width / 2) - (scaled_width / 2)

bin/gui_components/advanced_settings_window.py

@@ -4,6 +4,7 @@
 from bin.credentials import credentials_file_path
 from bin.settings import advanced_settings_are_correct, advanced_settings_read, advanced_settings_save
 from bin.root import get_root_permissions
+from bin.font_size import get_font_scale_factor
 
 DEFAULT_SCALE_FACTOR = 1
 DEFAULT_NM_USE = False
@@ -39,7 +40,7 @@ def __init__(self, main_gui, scale_factor=1):
             self.set_scale(DEFAULT_SCALE_FACTOR)
             self.set_nm_use(DEFAULT_NM_USE)
 
-        self.center_window(300 * scale_factor, 150 * scale_factor)
+        self.center_window(300 * scale_factor, 150 * scale_factor, self.save_button.cget("font"))
 
         self.grab_set()  # used to disable the underlying window
 
@@ -95,12 +96,14 @@ def get_nm_use(self):
     def set_nm_use(self, use):
         self.nm_use.set(use)
 
-    def center_window(self, width=300, height=200):
+    def center_window(self, width=300, height=200, font_name='TkDefaultFont'):
         # gets screen width and height
         screen_width = self.winfo_screenwidth()
         screen_height = self.winfo_screenheight()
 
+        font_factor = get_font_scale_factor(font_name)
+
         # calculates position x and y coordinates
-        x = (screen_width / 2) - (width / 2)
-        y = (screen_height / 2) - (height / 2)
-        self.geometry('%dx%d+%d+%d' % (width, height, x, y))
+        x = (screen_width / 2) - (width * font_factor / 2)
+        y = (screen_height / 2) - (height * font_factor / 2)
+        self.geometry('%dx%d+%d+%d' % (width * font_factor, height * font_factor, x, y))

bin/gui_components/manual_selection_window.py

@@ -4,6 +4,7 @@
 from bin.conf_util import get_available_servers_dict, global_stats_holder
 from bin.logging_util import get_logger
 from bin.pathUtil import CURRENT_PATH
+from bin.font_size import get_font_scale_factor
 from requests import ConnectionError as RequestsConnectionError
 
 SERVERS_DICT = get_available_servers_dict()
@@ -20,10 +21,11 @@ def __init__(self, parent, scale_factor=1):
         self.__imgicon__ = PhotoImage(file=path.join(CURRENT_PATH + "media", "manual.png"))
         self.tk.call('wm', 'iconphoto', self._w, self.__imgicon__)
 
-        self.center_window(300 * scale_factor, 190 * scale_factor)
         self.__init_listboxes__()
         self.__init_buttons__()
 
+        self.center_window(300 * scale_factor, 190 * scale_factor, self.accept_button.cget("font"))
+
         self.grab_set()  # used to disable the underlying window
 
         # creating stats holder
@@ -102,12 +104,17 @@ def cancel_pressed(self):
         self.grab_release() # to enable again the underlying window
         self.destroy()
 
-    def center_window(self, width=300, height=200):
+    def center_window(self, width=300, height=200, font_name='TkDefaultFont'):
         # gets screen width and height
         screen_width = self.winfo_screenwidth()
         screen_height = self.winfo_screenheight()
+        
+        font_factor = get_font_scale_factor(font_name) 
+
+        scaled_width = width * font_factor
+        scaled_height = height * font_factor
 
         # calculates position x and y coordinates
-        x = (screen_width / 2) - (width / 2)
-        y = (screen_height / 2) - (height / 2)
-        self.geometry('%dx%d+%d+%d' % (width, height, x, y))
+        x = (screen_width / 2) - (scaled_width / 2)
+        y = (screen_height / 2) - (scaled_height / 2)
+        self.geometry('%dx%d+%d+%d' % (scaled_width, scaled_height, x, y))

bin/gui_components/root_password_window.py

@@ -2,6 +2,7 @@
 import os
 from bin.pathUtil import CURRENT_PATH
 from bin.root import test_root_password, wrong_root_password
+from bin.font_size import get_font_scale_factor
 
 password_inserted = None
 
@@ -40,7 +41,7 @@ def __init__(self):
         # binding enter button to on_button_pressed function
         self.bind('<Return>', self.on_enter_pressed)
 
-        self.center_window(200, 80)
+        self.center_window(200, 80, self.ok_button.cget("font"))
 
     def on_enter_pressed(self, event):
         self.on_button_pressed()
@@ -58,13 +59,18 @@ def on_button_pressed(self):
             wrong_root_password()
             self.password_field.delete(0, END)
 
-    def center_window(self, width=300, height=200):
+    def center_window(self, width=300, height=200, font_name='TkDefaultFont'):
         # gets screen width and height
         screen_width = self.winfo_screenwidth()
         screen_height = self.winfo_screenheight()
+        
+        font_factor = get_font_scale_factor(font_name)
+
+        scaled_height = height * font_factor
+        scaled_width = width * font_factor
 
         # calculates position x and y coordinates
-        x = (screen_width / 2) - (width / 2)
-        y = (screen_height / 2) - (height / 2)
-        self.geometry('%dx%d+%d+%d' % (width, height, x, y))
+        x = (screen_width / 2) - (scaled_width / 2)
+        y = (screen_height / 2) - (scaled_height / 2)
+        self.geometry('%dx%d+%d+%d' % (scaled_width, scaled_height, x, y))