Skip to content

Commit 41f6874

Browse files
KuuCiVincent Chen
and
Vincent Chen
authored
Bump Composer 0.30.0 (#1772)
Co-authored-by: Vincent Chen <[email protected]>
1 parent 586110c commit 41f6874

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

Diff for: llmfoundry/callbacks/eval_output_logging_callback.py

+10-8
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,16 @@ def eval_batch_end(self, state: State, logger: Logger) -> None:
147147
def eval_end(self, state: State, logger: Logger) -> None:
148148
list_of_rows = all_gather_object(self.rows)
149149
rows = [row for rows in list_of_rows for row in rows]
150-
for dest_logger in logger.destinations:
151-
if not isinstance(dest_logger, ConsoleLogger):
152-
dest_logger.log_table(
153-
self.columns,
154-
rows,
155-
name=self.name,
156-
step=state.timestamp.batch.value,
157-
)
150+
# Only log if we have columns and a name
151+
if self.columns is not None and self.name is not None and rows:
152+
for dest_logger in logger.destinations:
153+
if not isinstance(dest_logger, ConsoleLogger):
154+
dest_logger.log_table(
155+
self.columns,
156+
rows,
157+
name=self.name,
158+
step=state.timestamp.batch.value,
159+
)
158160

159161
self.rows = []
160162
self.name = None

Diff for: setup.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
]
5353

5454
install_requires = [
55-
'mosaicml[libcloud,wandb,oci,gcs,mlflow]>=0.29.0,<0.30',
55+
'mosaicml[libcloud,wandb,oci,gcs,mlflow]>=0.30.0,<0.31',
5656
'mlflow>=2.14.1,<2.22',
5757
'accelerate>=0.25,<1.4', # for HF inference `device_map`
5858
'transformers>=v4.49.0,<4.50',
@@ -91,15 +91,15 @@
9191
]
9292

9393
extra_deps['databricks'] = [
94-
'mosaicml[databricks]>=0.29.0,<0.30',
94+
'mosaicml[databricks]>=0.30.0,<0.31',
9595
'numpy<2',
9696
'databricks-sql-connector>=3,<4',
9797
'databricks-connect==14.1.0',
9898
'lz4>=4,<5',
9999
]
100100

101101
extra_deps['tensorboard'] = [
102-
'mosaicml[tensorboard]>=0.29.0,<0.30',
102+
'mosaicml[tensorboard]>=0.30.0,<0.31',
103103
]
104104

105105
# Flash 2 group kept for backwards compatibility
@@ -110,7 +110,7 @@
110110
extra_deps['gpu'] = copy.deepcopy(extra_deps['gpu-flash2'])
111111

112112
extra_deps['peft'] = [
113-
'mosaicml[peft]>=0.29.0,<0.30',
113+
'mosaicml[peft]>=0.30.0,<0.31',
114114
]
115115

116116
extra_deps['openai'] = [

Diff for: tests/tp/test_tp_strategies.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,9 @@ def get_cfg(
141141

142142
def get_loss_array(trainer: Trainer):
143143
logger = trainer.logger.destinations[0]
144-
loss_array = logger.get_timeseries('loss/train/total')['loss/train/total'
145-
] # type: ignore
144+
loss_array = logger.get_timeseries( # type: ignore
145+
'loss/train/total',
146+
)['loss/train/total']
146147
return loss_array
147148

148149

0 commit comments

Comments
 (0)