fix: flaky tests (#84)

* fix: give mongodb more time during testing

* pin mongodb at 8.0.9

* increase sleep

* remove sleep

* close client after clean

* add 1 second delay again to test

* remove the second again

* serialize tests

* add 1 second sleep to verify

* remove the 1 second sleep again

Author: seriousme

.github/workflows/ci.yml

@@ -22,7 +22,6 @@ jobs:
           node-version: ${{ matrix.node-version }}
       - name: start mongodb
         run: | 
-          docker pull mongo:8
           npm run mongodb
       - name: Install
         run: |

package.json

@@ -6,14 +6,14 @@
   "scripts": {
     "lint": "eslint",
     "lint:fix": "eslint --fix",
-    "unit": "node --test --test-timeout=180000 test/*.js",
+    "unit": "node --test --test-timeout=180000 --test-concurrency=1 test/*.js",
     "test": "npm run lint && npm run unit",
     "coverage": "c8 --reporter=lcov npm run unit",
     "check-coverage": "c8 check-coverage --lines 90 --functions 98 --branches 85",
     "test:ci": "npm run lint && npm run coverage",
     "license-checker": "license-checker --production --onlyAllow='MIT;ISC;BSD-3-Clause;BSD-2-Clause;0BSD;Apache-2.0;Apache*'",
     "release": "read -p 'GITHUB_TOKEN: ' GITHUB_TOKEN && export GITHUB_TOKEN=$GITHUB_TOKEN && release-it --disable-metrics",
-    "mongodb": "docker run -d --rm --name mongodb -p 27017:27017 mongo:8"
+    "mongodb": "docker run -d --rm --name mongodb -p 27017:27017 mongo:8.0.9"
   },
   "release-it": {
     "github": {

test/abs.js

@@ -8,8 +8,21 @@ const mqemitterMongo = require('mqemitter-mongodb')
 const dbname = 'aedes-test'
 const mongourl = `mongodb://127.0.0.1/${dbname}`
 
-async function cleanDB (collections) {
+async function cleanDB () {
+  const mongoClient = new MongoClient(mongourl, { w: 1 })
+  const db = mongoClient.db(dbname)
+  await db.admin().ping()
+
+  const collections = [
+    db.collection('subscriptions'),
+    db.collection('retained'),
+    db.collection('will'),
+    db.collection('outgoing'),
+    db.collection('incoming')
+  ]
+
   await Promise.all(collections.map((c) => c.deleteMany({})))
+  await mongoClient.close()
 }
 
 function makeBuildEmitter (dbopts) {
@@ -19,9 +32,9 @@ function makeBuildEmitter (dbopts) {
   }
 }
 
-function makePersistence (dbopts, collections) {
+function makePersistence (dbopts) {
   return async function build () {
-    await cleanDB(collections)
+    await cleanDB()
     const instance = persistence(dbopts)
     // make intance.destroy close the broker as well
     const oldDestroy = instance.destroy.bind(instance)
@@ -35,34 +48,15 @@ function makePersistence (dbopts, collections) {
 }
 // Testing starts here.
 async function doTest () {
-  const mongoClient = new MongoClient(mongourl, { w: 1 })
-  const db = mongoClient.db(dbname)
-  test('Can connect to MongoDB', async (t) => {
-    await db.admin().ping()
-    t.assert.ok(true, 'Can connect to MongoDB')
-  })
-
-  const collections = [
-    db.collection('subscriptions'),
-    db.collection('retained'),
-    db.collection('will'),
-    db.collection('outgoing'),
-    db.collection('incoming')
-  ]
-
   const defaultDBopts = {
     url: mongourl
   }
   // run all tests from aedes-abstract-persistence
   abs({
     test,
     buildEmitter: makeBuildEmitter(defaultDBopts),
-    persistence: makePersistence(defaultDBopts, collections),
+    persistence: makePersistence(defaultDBopts),
     waitForReady: true,
   })
-
-  test.after(() => {
-    mongoClient.close()
-  })
 }
 doTest()