Revert "xhci-hub: Handle error condition with xhci_stop_device"

This is present in upstream as commit aaa7d1a ("usb: xhci: Handle
error condition in xhci_stop_device()"), which has a slightly better
resolution (since it went through the upstream review process).

This reverts commit fdb6672.

Signed-off-by: Nathan Chancellor <[email protected]>

Author: nathanchance

drivers/usb/host/xhci-hub.c

@@ -294,20 +294,11 @@ static int xhci_stop_device(struct xhci_hcd *xhci, int slot_id, int suspend)
 				return -ENOMEM;
 
 			}
-
-			ret = xhci_queue_stop_endpoint(xhci, command, slot_id,
-					i, suspend);
-			if (ret) {
-				spin_unlock_irqrestore(&xhci->lock, flags);
-				goto err_cmd_queue;
-			}
+			xhci_queue_stop_endpoint(xhci, command, slot_id, i,
+						 suspend);
 		}
 	}
-	ret = xhci_queue_stop_endpoint(xhci, cmd, slot_id, 0, suspend);
-	if (ret) {
-		spin_unlock_irqrestore(&xhci->lock, flags);
-		goto err_cmd_queue;
-	}
+	xhci_queue_stop_endpoint(xhci, cmd, slot_id, 0, suspend);
 	xhci_ring_cmd_db(xhci);
 	spin_unlock_irqrestore(&xhci->lock, flags);
 
@@ -318,8 +309,6 @@ static int xhci_stop_device(struct xhci_hcd *xhci, int slot_id, int suspend)
 		xhci_warn(xhci, "Timeout while waiting for stop endpoint command\n");
 		ret = -ETIME;
 	}
-
-err_cmd_queue:
 	xhci_free_command(xhci, cmd);
 	return ret;
 }