Skip to content

Commit 82a903e

Browse files
jwrdegoedeLee Jones
authored and
Lee Jones
committed
ASoC: rt5670: Correct RT5670_LDO_SEL_MASK
commit 5cacc6f5764e94fa753b2c1f5f7f1f3f74286e82 upstream. The RT5670_PWR_ANLG1 register has 3 bits to select the LDO voltage, so the correct mask is 0x7 not 0x3. Because of this wrong mask we were programming the ldo bits to a setting of binary 001 (0x05 & 0x03) instead of binary 101 when moving to SND_SOC_BIAS_PREPARE. According to the datasheet 001 is a reserved value, so no idea what it did, since the driver was working fine before I guess we got lucky and it does something which is ok. Fixes: 5e8351d ("ASoC: add RT5670 CODEC driver") Signed-off-by: Hans de Goede <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Lee Jones <[email protected]> Change-Id: Ibd35eacb7b7305fdc0ebe6b82e3145c5adb33909
1 parent 75deea3 commit 82a903e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/soc/codecs/rt5670.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@
754754
#define RT5670_PWR_VREF2_BIT 4
755755
#define RT5670_PWR_FV2 (0x1 << 3)
756756
#define RT5670_PWR_FV2_BIT 3
757-
#define RT5670_LDO_SEL_MASK (0x3)
757+
#define RT5670_LDO_SEL_MASK (0x7)
758758
#define RT5670_LDO_SEL_SFT 0
759759

760760
/* Power Management for Analog 2 (0x64) */

0 commit comments

Comments
 (0)