Roll out jest/consistent-test-it rule

Summary:
X-link: facebook/relay#4352

Changelog: [Internal]

drop-conflicts

Reviewed By: javache

Differential Revision: D46838374

fbshipit-source-id: b161e9ef4e3ba3c32fbaa5b4d1a5d84596dd26c6

Author: motiz88

packages/babel-plugin-codegen/__tests__/index-test.js

@@ -28,15 +28,15 @@ describe('Babel plugin inline view configs', () => {
   Object.keys(fixtures)
     .sort()
     .forEach(fixtureName => {
-      it(`can inline config for ${fixtureName}`, () => {
+      test(`can inline config for ${fixtureName}`, () => {
         expect(transform(fixtures[fixtureName], fixtureName)).toMatchSnapshot();
       });
     });
 
   Object.keys(failures)
     .sort()
     .forEach(fixtureName => {
-      it(`fails on inline config for ${fixtureName}`, () => {
+      test(`fails on inline config for ${fixtureName}`, () => {
         expect(() => {
           try {
             transform(failures[fixtureName], fixtureName);

packages/normalize-color/__tests__/normalizeColor-test.js

@@ -13,7 +13,7 @@
 
 import normalizeColor from '..';
 
-it('accepts only spec compliant colors', () => {
+test('accepts only spec compliant colors', () => {
   expect(normalizeColor('#abc')).not.toBe(null);
   expect(normalizeColor('#abcd')).not.toBe(null);
   expect(normalizeColor('#abcdef')).not.toBe(null);
@@ -29,12 +29,12 @@ it('accepts only spec compliant colors', () => {
   expect(normalizeColor(0xffffffff + 1)).toBe(null);
 });
 
-it('temporarilys accept floating point values for rgb', () => {
+test('temporarilys accept floating point values for rgb', () => {
   expect(normalizeColor('rgb(1.1, 2.1, 3.1)')).toBe(0x010203ff);
   expect(normalizeColor('rgba(1.1, 2.1, 3.1, 1.0)')).toBe(0x010203ff);
 });
 
-it('refuses non-spec compliant colors', () => {
+test('refuses non-spec compliant colors', () => {
   expect(normalizeColor('#00gg00')).toBe(null);
   expect(normalizeColor('rgb(1, 2, 3,)')).toBe(null);
   expect(normalizeColor('rgb(1, 2, 3')).toBe(null);
@@ -54,29 +54,29 @@ it('refuses non-spec compliant colors', () => {
   expect(normalizeColor('rgb(1%, 2%, 3%)')).toBe(null);
 });
 
-it('handles hex6 properly', () => {
+test('handles hex6 properly', () => {
   expect(normalizeColor('#000000')).toBe(0x000000ff);
   expect(normalizeColor('#ffffff')).toBe(0xffffffff);
   expect(normalizeColor('#ff00ff')).toBe(0xff00ffff);
   expect(normalizeColor('#abcdef')).toBe(0xabcdefff);
   expect(normalizeColor('#012345')).toBe(0x012345ff);
 });
 
-it('handles hex3 properly', () => {
+test('handles hex3 properly', () => {
   expect(normalizeColor('#000')).toBe(0x000000ff);
   expect(normalizeColor('#fff')).toBe(0xffffffff);
   expect(normalizeColor('#f0f')).toBe(0xff00ffff);
 });
 
-it('handles hex8 properly', () => {
+test('handles hex8 properly', () => {
   expect(normalizeColor('#00000000')).toBe(0x00000000);
   expect(normalizeColor('#ffffffff')).toBe(0xffffffff);
   expect(normalizeColor('#ffff00ff')).toBe(0xffff00ff);
   expect(normalizeColor('#abcdef01')).toBe(0xabcdef01);
   expect(normalizeColor('#01234567')).toBe(0x01234567);
 });
 
-it('handles rgb properly', () => {
+test('handles rgb properly', () => {
   expect(normalizeColor('rgb(0, 0, 0)')).toBe(0x000000ff);
   expect(normalizeColor('rgb(-1, -2, -3)')).toBe(0x000000ff);
   expect(normalizeColor('rgb(0, 0, 255)')).toBe(0x0000ffff);
@@ -87,7 +87,7 @@ it('handles rgb properly', () => {
   expect(normalizeColor('rgb(0 0 255)')).toBe(0x0000ffff);
 });
 
-it('handles rgba properly', () => {
+test('handles rgba properly', () => {
   expect(normalizeColor('rgba(0, 0, 0, 0.0)')).toBe(0x00000000);
   expect(normalizeColor('rgba(0, 0, 0, 0)')).toBe(0x00000000);
   expect(normalizeColor('rgba(0, 0, 0, -0.5)')).toBe(0x00000000);
@@ -100,7 +100,7 @@ it('handles rgba properly', () => {
   expect(normalizeColor('rgba(100 15 69 / 0.5)')).toBe(0x640f4580);
 });
 
-it('handles hsl properly', () => {
+test('handles hsl properly', () => {
   expect(normalizeColor('hsl(0, 0%, 0%)')).toBe(0x000000ff);
   expect(normalizeColor('hsl(360, 100%, 100%)')).toBe(0xffffffff);
   expect(normalizeColor('hsl(180, 50%, 50%)')).toBe(0x40bfbfff);
@@ -115,7 +115,7 @@ it('handles hsl properly', () => {
   expect(normalizeColor('hsl(180 50% 50%)')).toBe(0x40bfbfff);
 });
 
-it('handles hsla properly', () => {
+test('handles hsla properly', () => {
   expect(normalizeColor('hsla(0, 0%, 0%, 0)')).toBe(0x00000000);
   expect(normalizeColor('hsla(360, 100%, 100%, 1)')).toBe(0xffffffff);
   expect(normalizeColor('hsla(360, 100%, 100%, 0)')).toBe(0xffffff00);
@@ -126,7 +126,7 @@ it('handles hsla properly', () => {
   expect(normalizeColor('hsla(180 50% 50% / 0.2)')).toBe(0x40bfbf33);
 });
 
-it('handles hwb properly', () => {
+test('handles hwb properly', () => {
   expect(normalizeColor('hwb(0, 0%, 100%)')).toBe(0x000000ff);
   expect(normalizeColor('hwb(0, 100%, 0%)')).toBe(0xffffffff);
   expect(normalizeColor('hwb(0, 0%, 0%)')).toBe(0xff0000ff);
@@ -137,20 +137,20 @@ it('handles hwb properly', () => {
   expect(normalizeColor('hwb(70 50% 0%)')).toBe(0xeaff80ff);
 });
 
-it('handles named colors properly', () => {
+test('handles named colors properly', () => {
   expect(normalizeColor('red')).toBe(0xff0000ff);
   expect(normalizeColor('transparent')).toBe(0x00000000);
   expect(normalizeColor('peachpuff')).toBe(0xffdab9ff);
 });
 
-it('handles number colors properly', () => {
+test('handles number colors properly', () => {
   expect(normalizeColor(0x00000000)).toBe(0x00000000);
   expect(normalizeColor(0xff0000ff)).toBe(0xff0000ff);
   expect(normalizeColor(0xffffffff)).toBe(0xffffffff);
   expect(normalizeColor(0x01234567)).toBe(0x01234567);
 });
 
-it('returns the same color when it is already normalized', () => {
+test('returns the same color when it is already normalized', () => {
   const normalizedColor = normalizeColor('red') || 0;
   expect(normalizeColor(normalizedColor)).toBe(normalizedColor);
 });

packages/polyfills/__tests__/Object.es8-test.js

@@ -19,11 +19,11 @@ describe('Object (ES8)', () => {
   });
 
   describe('Object.entries', () => {
-    it('should have a length of 1', () => {
+    test('should have a length of 1', () => {
       expect(Object.entries.length).toBe(1);
     });
 
-    it('should check for type', () => {
+    test('should check for type', () => {
       expect(Object.entries.bind(null, null)).toThrow(
         TypeError('Object.entries called on non-object'),
       );
@@ -36,7 +36,7 @@ describe('Object (ES8)', () => {
       expect(Object.entries.bind(null, 'abc')).not.toThrow();
     });
 
-    it('should return enumerable entries', () => {
+    test('should return enumerable entries', () => {
       const foo = Object.defineProperties(
         {},
         {
@@ -54,7 +54,7 @@ describe('Object (ES8)', () => {
       ]);
     });
 
-    it('should work with proto-less objects', () => {
+    test('should work with proto-less objects', () => {
       const foo = Object.create(null, {
         x: {value: 10, enumerable: true},
         y: {value: 20},
@@ -63,7 +63,7 @@ describe('Object (ES8)', () => {
       expect(Object.entries(foo)).toEqual([['x', 10]]);
     });
 
-    it('should return only own entries', () => {
+    test('should return only own entries', () => {
       const foo = Object.create(
         {z: 30},
         {
@@ -75,7 +75,7 @@ describe('Object (ES8)', () => {
       expect(Object.entries(foo)).toEqual([['x', 10]]);
     });
 
-    it('should convert to object primitive string', () => {
+    test('should convert to object primitive string', () => {
       expect(Object.entries('ab')).toEqual([
         ['0', 'a'],
         ['1', 'b'],
@@ -84,11 +84,11 @@ describe('Object (ES8)', () => {
   });
 
   describe('Object.values', () => {
-    it('should have a length of 1', () => {
+    test('should have a length of 1', () => {
       expect(Object.values.length).toBe(1);
     });
 
-    it('should check for type', () => {
+    test('should check for type', () => {
       expect(Object.values.bind(null, null)).toThrow(
         TypeError('Object.values called on non-object'),
       );
@@ -97,7 +97,7 @@ describe('Object (ES8)', () => {
       expect(Object.values.bind(null, {})).not.toThrow();
     });
 
-    it('should return enumerable values', () => {
+    test('should return enumerable values', () => {
       const foo = Object.defineProperties(
         {},
         {
@@ -112,7 +112,7 @@ describe('Object (ES8)', () => {
       expect(Object.values(bar)).toEqual([10, 20]);
     });
 
-    it('should work with proto-less objects', () => {
+    test('should work with proto-less objects', () => {
       const foo = Object.create(null, {
         x: {value: 10, enumerable: true},
         y: {value: 20},
@@ -121,7 +121,7 @@ describe('Object (ES8)', () => {
       expect(Object.values(foo)).toEqual([10]);
     });
 
-    it('should return only own values', () => {
+    test('should return only own values', () => {
       const foo = Object.create(
         {z: 30},
         {
@@ -133,7 +133,7 @@ describe('Object (ES8)', () => {
       expect(Object.values(foo)).toEqual([10]);
     });
 
-    it('should convert to object primitive string', () => {
+    test('should convert to object primitive string', () => {
       expect(Object.values('ab')).toEqual(['a', 'b']);
     });
   });

packages/react-native-codegen/e2e/__tests__/components/GenerateComponentDescriptorH-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GenerateComponentDescriptorH can generate for '${fixture}'`, () => {
+  test(`GenerateComponentDescriptorH can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/components/GenerateComponentHObjCpp-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GenerateComponentHObjCpp can generate for '${fixture}'`, () => {
+  test(`GenerateComponentHObjCpp can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/components/GenerateEventEmitterCpp-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GenerateEventEmitterCpp can generate for '${fixture}'`, () => {
+  test(`GenerateEventEmitterCpp can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/components/GenerateEventEmitterH-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GenerateEventEmitterH can generate for '${fixture}'`, () => {
+  test(`GenerateEventEmitterH can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/components/GeneratePropsCpp-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GeneratePropsCpp can generate for '${fixture}'`, () => {
+  test(`GeneratePropsCpp can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/components/GeneratePropsH-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GeneratePropsH can generate for '${fixture}'`, () => {
+  test(`GeneratePropsH can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/components/GeneratePropsJavaDelegate-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GeneratePropsJavaDelegate can generate for '${fixture}'`, () => {
+  test(`GeneratePropsJavaDelegate can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/components/GeneratePropsJavaInterface-test.js

@@ -21,7 +21,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GeneratePropsJavaInterface can generate for '${fixture}'`, () => {
+  test(`GeneratePropsJavaInterface can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema, undefined, false);

packages/react-native-codegen/e2e/__tests__/components/GenerateShadowNodeCpp-test.js

@@ -21,7 +21,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GenerateShadowNodeCpp can generate for '${fixture}'`, () => {
+  test(`GenerateShadowNodeCpp can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema, undefined, false);

packages/react-native-codegen/e2e/__tests__/components/GenerateShadowNodeH-test.js

@@ -21,7 +21,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GenerateShadowNodeH can generate for '${fixture}'`, () => {
+  test(`GenerateShadowNodeH can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema, undefined, false);

packages/react-native-codegen/e2e/__tests__/components/GenerateViewConfigJs-test.js

@@ -22,7 +22,7 @@ const fixtures = fs.readdirSync(FIXTURE_DIR);
 const parser = new FlowParser();
 
 fixtures.forEach(fixture => {
-  it(`GenerateViewConfigJs can generate for '${fixture}'`, () => {
+  test(`GenerateViewConfigJs can generate for '${fixture}'`, () => {
     const libName = 'RNCodegenModuleFixtures';
     const schema = parser.parseFile(`${FIXTURE_DIR}/${fixture}`);
     const output = generator.generate(libName, schema);

packages/react-native-codegen/e2e/__tests__/modules/GenerateModuleCpp-test.js

@@ -38,13 +38,13 @@ function getModules(): SchemaType {
 }
 
 describe('GenerateModuleCpp', () => {
-  it('can generate an implementation file NativeModule specs', () => {
+  test('can generate an implementation file NativeModule specs', () => {
     const libName = 'RNCodegenModuleFixtures';
     const output = generator.generate(libName, getModules(), undefined, false);
     expect(output.get(libName + 'JSI-generated.cpp')).toMatchSnapshot();
   });
 
-  it('can generate a header file NativeModule specs with assume nonnull enabled', () => {
+  test('can generate a header file NativeModule specs with assume nonnull enabled', () => {
     const libName = 'RNCodegenModuleFixtures';
     const output = generator.generate(libName, getModules(), undefined, true);
     expect(output.get(libName + 'JSI-generated.cpp')).toMatchSnapshot();

packages/react-native-codegen/e2e/__tests__/modules/GenerateModuleH-test.js

@@ -38,13 +38,13 @@ function getModules(): SchemaType {
 }
 
 describe('GenerateModuleH', () => {
-  it('can generate a header file NativeModule specs', () => {
+  test('can generate a header file NativeModule specs', () => {
     const libName = 'RNCodegenModuleFixtures';
     const output = generator.generate(libName, getModules(), undefined, false);
     expect(output.get(libName + 'JSI.h')).toMatchSnapshot();
   });
 
-  it('can generate a header file NativeModule specs with assume nonnull enabled', () => {
+  test('can generate a header file NativeModule specs with assume nonnull enabled', () => {
     const libName = 'RNCodegenModuleFixtures';
     const output = generator.generate(libName, getModules(), undefined, true);
     expect(output.get(libName + 'JSI.h')).toMatchSnapshot();

packages/react-native-codegen/e2e/__tests__/modules/GenerateModuleObjCpp-test.js

@@ -38,19 +38,19 @@ function getModules(): SchemaType {
 }
 
 describe('GenerateModuleObjCpp', () => {
-  it('can generate a header file NativeModule specs', () => {
+  test('can generate a header file NativeModule specs', () => {
     const libName = 'RNCodegenModuleFixtures';
     const output = generator.generate(libName, getModules(), undefined, false);
     expect(output.get(libName + '.h')).toMatchSnapshot();
   });
 
-  it('can generate a header file NativeModule specs with assume nonnull enabled', () => {
+  test('can generate a header file NativeModule specs with assume nonnull enabled', () => {
     const libName = 'RNCodegenModuleFixtures';
     const output = generator.generate(libName, getModules(), undefined, true);
     expect(output.get(libName + '.h')).toMatchSnapshot();
   });
 
-  it('can generate an implementation file NativeModule specs', () => {
+  test('can generate an implementation file NativeModule specs', () => {
     const libName = 'RNCodegenModuleFixtures';
     const output = generator.generate(libName, getModules(), undefined, false);
     expect(output.get(libName + '-generated.mm')).toMatchSnapshot();