Skip to content

Commit 54c8e9f

Browse files
cipolleschimotiz88
authored andcommitted
Skip prebuilds for DynamicFrameworks CI jobs (facebook#56593)
1 parent 5e3a3ba commit 54c8e9f

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

.github/actions/test-ios-helloworld/action.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,23 @@ runs:
3333
- name: Run yarn install again, with the correct hermes version
3434
uses: ./.github/actions/yarn-install
3535
- name: Download ReactNativeDependencies
36+
if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
3637
uses: actions/download-artifact@v7
3738
with:
3839
name: ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz
3940
path: /tmp/third-party
4041
- name: Print third-party folder
42+
if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
4143
shell: bash
4244
run: ls -lR /tmp/third-party
4345
- name: Download React Native Prebuilds
46+
if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
4447
uses: actions/download-artifact@v7
4548
with:
4649
name: ReactCore${{ inputs.flavor }}.xcframework.tar.gz
4750
path: /tmp/ReactCore
4851
- name: Print ReactCore folder
52+
if: ${{ inputs.use-frameworks != 'DynamicFrameworks' }}
4953
shell: bash
5054
run: ls -lR /tmp/ReactCore
5155
- name: Install iOS dependencies - Configuration ${{ inputs.flavor }};
@@ -56,11 +60,11 @@ runs:
5660
5761
if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
5862
args+=(--frameworks dynamic)
63+
else
64+
export RCT_USE_LOCAL_RN_DEP="/tmp/third-party/ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz"
65+
export RCT_TESTONLY_RNCORE_TARBALL_PATH="/tmp/ReactCore/ReactCore${{ inputs.flavor }}.xcframework.tar.gz"
5966
fi
6067
61-
export RCT_USE_LOCAL_RN_DEP="/tmp/third-party/ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz"
62-
export RCT_TESTONLY_RNCORE_TARBALL_PATH="/tmp/ReactCore/ReactCore${{ inputs.flavor }}.xcframework.tar.gz"
63-
6468
yarn bootstrap ios "${args[@]}" | cat
6569
6670
- name: Run Helloworld tests

0 commit comments

Comments
 (0)