Commit e681ffc
committed
Skip Hermes nightly override on stable branches
The test-ios-rntester, test-ios-helloworld actions and the
test_android_helloworld job unconditionally run use-hermes-nightly.js,
which replaces the pinned Hermes version with the latest nightly from
npm. On stable/release branches this is wrong: the pinned version from
version.properties should be used instead.
Add a `use-hermes-nightly` input (default true for backward compat) to
both composite actions, and guard the nightly override steps behind it.
In test-all.yml, pass `!endsWith(github.ref_name, '-stable')` so that
pushes to *-stable branches use the pinned Hermes version.1 parent 6614fe7 commit e681ffc
3 files changed
Lines changed: 19 additions & 0 deletions
File tree
- .github
- actions
- test-ios-helloworld
- test-ios-rntester
- workflows
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
13 | 17 | | |
14 | 18 | | |
15 | 19 | | |
| |||
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
| 31 | + | |
27 | 32 | | |
28 | 33 | | |
29 | 34 | | |
30 | 35 | | |
| 36 | + | |
31 | 37 | | |
32 | 38 | | |
33 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
| |||
33 | 37 | | |
34 | 38 | | |
35 | 39 | | |
| 40 | + | |
36 | 41 | | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
| 45 | + | |
40 | 46 | | |
41 | 47 | | |
42 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
| |||
133 | 134 | | |
134 | 135 | | |
135 | 136 | | |
| 137 | + | |
136 | 138 | | |
137 | 139 | | |
138 | 140 | | |
| |||
152 | 154 | | |
153 | 155 | | |
154 | 156 | | |
| 157 | + | |
155 | 158 | | |
156 | 159 | | |
157 | 160 | | |
| |||
499 | 502 | | |
500 | 503 | | |
501 | 504 | | |
| 505 | + | |
502 | 506 | | |
503 | 507 | | |
504 | 508 | | |
505 | 509 | | |
| 510 | + | |
506 | 511 | | |
507 | 512 | | |
508 | 513 | | |
| |||
536 | 541 | | |
537 | 542 | | |
538 | 543 | | |
| 544 | + | |
539 | 545 | | |
540 | 546 | | |
541 | 547 | | |
| |||
558 | 564 | | |
559 | 565 | | |
560 | 566 | | |
| 567 | + | |
561 | 568 | | |
562 | 569 | | |
563 | 570 | | |
| |||
0 commit comments