add script to install shellcheck

Author: moukoublen

Makefile

@@ -51,6 +51,5 @@ ci-mod: mod
 	./scripts/git-check-dirty
 
 .PHONY: ci-sh
-ci-sh: shfmt
-	@./scripts/sh-checks
+ci-sh: shfmt shellcheck
 	@./scripts/git-check-dirty

scripts/foreach-script

@@ -0,0 +1,19 @@
+#!/usr/bin/env bash
+
+set -e
+#set -u
+set -o pipefail
+
+# should be called from root dir.
+
+find ./ \
+  -type f \
+  -not -path './.git/*' \
+  -not -path './vendor/*' \
+  \( -name '*.bash' -o -name '*.sh' -o -executable \) \
+  -print0 | while IFS= read -r -d '' file; do
+  if file "${file}" | grep -qE 'shell script|POSIX shell script|Bourne-Again shell script|bash script|a sh script'; then
+    echo "${*} ${file}"
+    "${@}" "${file}"
+  fi
+done

scripts/install-shellcheck

@@ -0,0 +1,93 @@
+#!/usr/bin/env bash
+
+set -e
+#set -u
+set -o pipefail
+
+get_protoc_latest_version() {
+  JS_BODY=$(curl --silent --fail --location "https://api.github.com/repos/koalaman/shellcheck/releases/latest")
+  echo "${JS_BODY}" | jq '.tag_name' --raw-output
+}
+
+package_os() {
+  case "$(uname)" in
+    "Darwin")
+      echo "darwin"
+      ;;
+    "Linux")
+      echo "linux"
+      ;;
+  esac
+}
+
+package_arch() {
+  local arch
+  arch="$(uname -m | tr '[:upper:]' '[:lower:]')"
+  case "${arch}" in
+    "x86_64")
+      echo "x86_64"
+      ;;
+    "aarch64")
+      echo "aarch64"
+      ;;
+    "arm64")
+      echo "aarch64"
+      ;;
+  esac
+}
+
+VERSION=""
+DESTINATION_DIR=""
+
+UNKNOWN_ARGS=()
+while (($#)); do
+  case "${1}" in
+    -v | --version)
+      VERSION="${2}"
+      shift 2
+      ;;
+    -d | --destination)
+      DESTINATION_DIR="${2}"
+      shift 2
+      ;;
+    *)
+      UNKNOWN_ARGS+=("${1}")
+      shift
+      ;;
+  esac
+done
+
+if [[ ${VERSION} == "" ]]; then
+  VERSION="$(get_protoc_latest_version)"
+fi
+
+if [[ ${DESTINATION_DIR} == "" ]]; then
+  echo "missing destination argument"
+  exit 1
+fi
+
+# uninstall previous version
+rm -rf "${DESTINATION_DIR}"/bin/shellcheck
+
+DL_URL="https://github.com/koalaman/shellcheck/releases/download/${VERSION}/shellcheck-${VERSION}.$(package_os).$(package_arch).tar.xz"
+
+curl \
+  --silent \
+  --fail \
+  --location \
+  "${DL_URL}" \
+  -o "${DESTINATION_DIR}/shellcheck.tar.xz"
+
+tar \
+  --extract \
+  --xz \
+  --file="${DESTINATION_DIR}/shellcheck.tar.xz" \
+  --strip-components=1 \
+  --directory="${DESTINATION_DIR}/bin"
+
+rm -f "${DESTINATION_DIR}/shellcheck.tar.xz"
+rm -f "${DESTINATION_DIR}/bin/LICENSE.txt"
+rm -f "${DESTINATION_DIR}/bin/README.txt"
+
+# to update all dates in order for make file to get it as new (check stat "${DESTINATION_DIR}/bin/shellcheck")
+touch "${DESTINATION_DIR}/bin/shellcheck"

scripts/tools.mk

@@ -178,4 +178,16 @@ $(TOOLS_BIN)/shfmt: $(TOOLS_DB)/shfmt.$(SHFMT_VER).$(GO_VER).ver
 
 .PHONY: shfmt
 shfmt: $(TOOLS_BIN)/shfmt
-## <shfmt>
+	@./scripts/foreach-script $(TOOLS_BIN)/shfmt --simplify --language-dialect auto --case-indent --indent 2 --write
+## </shfmt>
+
+## <shellcheck>
+# https://github.com/koalaman/shellcheck/releases
+SHELLCHECK_VER := v0.10.0
+$(TOOLS_BIN)/shellcheck: $(TOOLS_DB)/shellcheck.$(SHELLCHECK_VER).ver | $(TOOLS_BIN)
+	@./scripts/install-shellcheck --version $(SHELLCHECK_VER) --destination $(TOOLS_DIR)
+
+.PHONY: shellcheck
+shellcheck: $(TOOLS_BIN)/shellcheck
+	@./scripts/foreach-script $(TOOLS_BIN)/shellcheck --external-sources --format=tty --severity=info
+## </shellcheck>